Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate as much as possible to pyproject.toml #12850

Merged
merged 18 commits into from
Mar 6, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Feb 24, 2023

Description

I migrated as much build logic as possible to pyproject.toml for cudf, dask_cudf, and custreamz. A couple of notes:

  • I didn't move cudf_kafka because it is currently still using a pure setuptools build with Cython files. We may as well do the pyproject.toml migration there after we have also done the scikit-build conversion since there's a lot of logic that can't be removed from setup.py until then. I'm also not entirely confident that everything will work as expected if we move data to pyproject.toml without switching to scikit-build based on issues like the ones mentioned in this SO post about Cython and project data stored in pyproject.toml.
  • I could get rid of setup.py entirely for custreamz at this point, but I expect that we'll run into a host of additional issues when we do eventually move to requiring pip install X instead of python setup.py X across RAPIDS and I'd rather deal with all of those at the same time with our main packages rather than using an esoteric package like custreamz as the test case.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 24, 2023
@vyasr vyasr requested a review from a team as a code owner February 24, 2023 23:27
@vyasr vyasr self-assigned this Feb 24, 2023
@vyasr vyasr requested a review from a team as a code owner February 24, 2023 23:27
@github-actions github-actions bot added the Python Affects Python cuDF API. label Feb 24, 2023
@vyasr vyasr requested a review from a team as a code owner February 25, 2023 00:02
@github-actions github-actions bot added the ci label Feb 25, 2023
Comment on lines +53 to +54
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.10",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have the python 3.9 classifier consistent across all .toml's? Either we drop it everywhere or keep it incase python 3.9 packages are making a comeback.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. We removed it in rmm so I'm going to continue removing it everywhere else during this transition for now. We can readjust later if we want to.

Copy link
Contributor

@galipremsagar galipremsagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some non-blocking comments.

python/dask_cudf/pyproject.toml Outdated Show resolved Hide resolved
Copy link
Contributor

@galipremsagar galipremsagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Veirifed the backend dispatching works fine 👍

@vyasr
Copy link
Contributor Author

vyasr commented Mar 6, 2023

/merge

@rapids-bot rapids-bot bot merged commit 7dade51 into rapidsai:branch-23.04 Mar 6, 2023
@vyasr vyasr deleted the feat/all_pyproject branch March 6, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants