Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable testing cudf.pandas unit tests for all minor versions of pandas #16595

Merged
merged 43 commits into from
Aug 23, 2024
Merged

Enable testing cudf.pandas unit tests for all minor versions of pandas #16595

merged 43 commits into from
Aug 23, 2024

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Aug 19, 2024 •
edited
Loading

Description

Fixes: #16537

This PR enables testing cudf.pandas unit tests with all minor versions of pandas-2

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 19, 2024
@github-actions github-actions bot added Python Affects Python cuDF API. cudf.pandas Issues specific to cudf.pandas labels Aug 20, 2024
@galipremsagar galipremsagar changed the title test ci Enable testing cudf.pandas unit tests for all minor versions of pandas Aug 20, 2024
@galipremsagar galipremsagar marked this pull request as ready for review August 20, 2024 16:44
@galipremsagar galipremsagar requested review from a team as code owners August 20, 2024 16:44
bdice
bdice reviewed Aug 21, 2024
View reviewed changes
.github/workflows/pr.yaml Outdated Show resolved Hide resolved
.github/workflows/pr.yaml Outdated Show resolved Hide resolved
.github/workflows/pr.yaml Outdated Show resolved Hide resolved
.github/workflows/pr.yaml Outdated Show resolved Hide resolved
python/cudf/cudf_pandas_tests/test_cudf_pandas.py Outdated Show resolved Hide resolved
python/cudf/cudf_pandas_tests/test_profiler.py Outdated Show resolved Hide resolved
raydouglass
raydouglass reviewed Aug 21, 2024
View reviewed changes
.github/workflows/pr.yaml Outdated Show resolved Hide resolved
.github/workflows/pr.yaml Outdated Show resolved Hide resolved
seberg added a commit to seberg/cudf that referenced this pull request Aug 21, 2024
@seberg @galipremsagar
TST: Apply cudf_pandas_test fixes from rapidsaigh-16595
caccd02 
Co-authored-by: galipremsagar <sagarprem75@gmail.com>
@seberg seberg mentioned this pull request Aug 21, 2024
Merged
bdice
bdice reviewed Aug 22, 2024
View reviewed changes
ci/cudf_pandas_scripts/fetch_pandas_versions.py Outdated Show resolved Hide resolved
ci/cudf_pandas_scripts/run_tests.sh Outdated Show resolved Hide resolved
ci/cudf_pandas_scripts/run_tests.sh Outdated Show resolved Hide resolved
@galipremsagar @bdice
Apply suggestions from code review
5fcf7c5 
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
@vyasr
Copy link
Contributor

vyasr commented Aug 22, 2024

The reason just testing oldest and latest versions would not be sufficient with cudf.pandas is pandas-2.x especially has had multiple breaking changes across minor versions in-between too. That's why this testing.

The main thing is that we want to make sure that cudf.pandas will at least import normally for a wider range of packages. The way that cudf.pandas works, it is much easier to make a change that actually prevents import pandas as pd from working. We're OK if some particular bit of functionality only works with pandas 2.1.2 but not 2.0.1 because we can only realistically match exactly the behavior of one pandas version at a time due to all the edge cases in pandas behavior. We are not OK with a particular pandas version (supposedly within our supported range) being completely unusable.

bdice
bdice approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion for improvement, otherwise seems fine.

ci/cudf_pandas_scripts/run_tests.sh Outdated Show resolved Hide resolved
ci/cudf_pandas_scripts/fetch_pandas_versions.py Outdated Show resolved Hide resolved
@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 91f304e into rapidsai:branch-24.10 Aug 23, 2024
83 checks passed
@jakirkham jakirkham mentioned this pull request Aug 23, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@msarahan msarahan Awaiting requested review from msarahan msarahan is a code owner automatically assigned from rapidsai/ci-codeowners

@Matt711 Matt711 Awaiting requested review from Matt711 Matt711 is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@vyasr vyasr Awaiting requested review from vyasr

@raydouglass raydouglass Awaiting requested review from raydouglass

@mroeschke mroeschke Awaiting requested review from mroeschke

Assignees
No one assigned
Labels
cudf.pandas Issues specific to cudf.pandas improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Add CI job to validate that cudf.pandas can be imported for all supported minor versions of pandas
6 participants
@galipremsagar @bdice @seberg @vyasr @raydouglass @mroeschke