Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor of rolling_window implementation. #8158

Merged
merged 27 commits into from
May 24, 2021
Merged

Refactor of rolling_window implementation. #8158

merged 27 commits into from
May 24, 2021

Commits on Apr 23, 2021

  1. First pass. Aggregation hierarchy modified. Still need to apply to th… 

    …e rolling_window interface.
    @nvdbaranec
    nvdbaranec committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    6cf25ab View commit details
    Browse the repository at this point in the history

  2. Enforce rolling_aggregation types for all rolling interfaces.

    @nvdbaranec
    nvdbaranec committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    5e38bef View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2021

  1. Merge branch 'branch-0.20' into derived_aggregations

    @nvdbaranec
    nvdbaranec committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    08bf0c2 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2021

  1. Change various rolling interfaces to take aggregations directly inste… 

    …ad of unique_ptrs.
    @nvdbaranec
    nvdbaranec committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    18ba94f View commit details
    Browse the repository at this point in the history

  2. Refactor get_simple_aggregations to use the visitor pattern similar t… 

    …o the finalizer.
    @nvdbaranec
    nvdbaranec committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    6426541 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2021

  1. Merge branch 'branch-0.20' into derived_aggregations

    @nvdbaranec
    nvdbaranec committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    80f47f9 View commit details
    Browse the repository at this point in the history

  2. Rough, incomplete draft. Merged with derived aggregations refactor PR.

    @nvdbaranec
    nvdbaranec committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    e98a74f View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2021

  1. Add a simple aggregations collector visitor pattern class modelled af… 

    …ter the finalizer. Refactor groupby to use this mechanism. Change finalizer

to not be an abstract class in the interest of keeping it extensible for rolling window and other users.
    @nvdbaranec
    nvdbaranec committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    6e2e3d6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'derived_aggregations' into rolling_refactor

    @nvdbaranec
    nvdbaranec committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    ee4cd4b View commit details
    Browse the repository at this point in the history

  3. Update python bindings for aggregation / rolling_aggregation changes.

    @nvdbaranec
    nvdbaranec committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    bc5030a View commit details
    Browse the repository at this point in the history

  4. Merge branch 'branch-0.20' into derived_aggregations

    @nvdbaranec
    nvdbaranec committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    da0eea2 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2021

  1. Python formatting.

    @nvdbaranec
    nvdbaranec committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    a7f38b6 View commit details
    Browse the repository at this point in the history

  2. More python formatting.

    @nvdbaranec
    nvdbaranec committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    000f459 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2021

  1. Merge branch 'derived_aggregations' into rolling_refactor

    @nvdbaranec
    nvdbaranec committed May 3, 2021
    Configuration menu
    Copy the full SHA
    2b5e620 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2021

  1. Make the finalize() function const.

    @nvdbaranec
    nvdbaranec committed May 4, 2021
    Configuration menu
    Copy the full SHA
    307cce9 View commit details
    Browse the repository at this point in the history

  2. Refactor the code to use the collector -> finalizer method similar to… 

    … groupby.
    @nvdbaranec
    nvdbaranec committed May 4, 2021
    Configuration menu
    Copy the full SHA
    d585a9f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'derived_aggregations' into rolling_refactor

    @nvdbaranec
    nvdbaranec committed May 4, 2021
    Configuration menu
    Copy the full SHA
    fb417c7 View commit details
    Browse the repository at this point in the history

  4. Documentation pass.

    @nvdbaranec
    nvdbaranec committed May 4, 2021
    Configuration menu
    Copy the full SHA
    beab7c6 View commit details
    Browse the repository at this point in the history

  5. Commongize test version of is_rolling_supported(). Remove is_rolling_… 

    …string_specialization(). Fix some

copyright headers.
    @nvdbaranec
    nvdbaranec committed May 4, 2021
    Configuration menu
    Copy the full SHA
    f6452f1 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'branch-0.20' into derived_aggregations

    @nvdbaranec
    nvdbaranec committed May 4, 2021
    Configuration menu
    Copy the full SHA
    717595e View commit details
    Browse the repository at this point in the history

Commits on May 6, 2021

  1. Merge branch 'derived_aggregations' into rolling_refactor

    @nvdbaranec
    nvdbaranec committed May 6, 2021
    Configuration menu
    Copy the full SHA
    ea1afe3 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2021

  1. Merge branch 'branch-0.20' into rolling_refactor

    @nvdbaranec
    nvdbaranec committed May 7, 2021
    Configuration menu
    Copy the full SHA
    57f55f7 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2021

  1. Minor review comments.

    @nvdbaranec
    nvdbaranec committed May 13, 2021
    Configuration menu
    Copy the full SHA
    d553680 View commit details
    Browse the repository at this point in the history

  2. Simplify SFINAE and specialization logic using a corresponding_rollin… 

    …g_operator functor.
    @nvdbaranec
    nvdbaranec committed May 13, 2021
    Configuration menu
    Copy the full SHA
    9da7619 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2021

  1. Grammar change.

    @nvdbaranec
    nvdbaranec committed May 14, 2021
    Configuration menu
    Copy the full SHA
    1bad5ea View commit details
    Browse the repository at this point in the history

Commits on May 17, 2021

  1. Merge branch 'branch-21.06' into rolling_refactor

    @nvdbaranec
    nvdbaranec committed May 17, 2021
    Configuration menu
    Copy the full SHA
    b4a5f15 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2021

  1. Add some extra parentheses to DeviceRolling::is_supported() logic. Ad… 

    …ded a note about removing

some code once is_valid_aggregation<> gets cleaned up a bit.
    @nvdbaranec
    nvdbaranec committed May 24, 2021
    Configuration menu
    Copy the full SHA
    1b22c91 View commit details
    Browse the repository at this point in the history