Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Pin max dask and distributed versions to 2021.09.1 #9286

Merged
merged 5 commits into from
Sep 23, 2021
Merged

[REVIEW] Pin max dask and distributed versions to 2021.09.1 #9286

merged 5 commits into from
Sep 23, 2021

Conversation

galipremsagar
Copy link
Contributor

This PR pins max dask & distributed versions to 2021.09.1 for 21.10 release.

@galipremsagar galipremsagar requested review from a team as code owners September 23, 2021 16:15
@galipremsagar galipremsagar self-assigned this Sep 23, 2021
@github-actions github-actions bot added conda Python Affects Python cuDF API. labels Sep 23, 2021
@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer improvement Improvement / enhancement to an existing function and removed gpuCI Python Affects Python cuDF API. labels Sep 23, 2021
@galipremsagar galipremsagar added the non-breaking Non-breaking change label Sep 23, 2021
This was referenced Sep 23, 2021
Merged
Merged
Merged
@codecov
Copy link

codecov bot commented Sep 23, 2021 •
edited
Loading

Codecov Report

Merging #9286 (2ddb665) into branch-21.10 (3ee3ecf) will decrease coverage by 0.05%.
The diff coverage is 12.05%.

❗ Current head 2ddb665 differs from pull request most recent head 9c3ac38. Consider uploading reports for the commit 9c3ac38 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.10    #9286      +/-   ##
================================================
- Coverage         10.85%   10.80%   -0.06%     
================================================
  Files               115      116       +1     
  Lines             19158    19318     +160     
================================================
+ Hits               2080     2087       +7     
- Misses            17078    17231     +153
Impacted Files Coverage Δ
python/cudf/cudf/__init__.py 0.00% <ø> (ø)
python/cudf/cudf/_lib/__init__.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/column.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/dataframe.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/multiindex.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/csv.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/orc.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/parquet.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/text.py 0.00% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ced66b5...9c3ac38. Read the comment docs.

galipremsagar
galipremsagar commented Sep 23, 2021
View reviewed changes
conda/environments/cudf_dev_cuda11.0.yml Outdated Show resolved Hide resolved
conda/environments/cudf_dev_cuda11.2.yml Outdated Show resolved Hide resolved
conda/recipes/custreamz/meta.yaml Outdated Show resolved Hide resolved
conda/recipes/dask-cudf/meta.yaml Outdated Show resolved Hide resolved
conda/recipes/dask-cudf/meta.yaml Outdated Show resolved Hide resolved
python/custreamz/dev_requirements.txt Outdated Show resolved Hide resolved
python/dask_cudf/dev_requirements.txt Outdated Show resolved Hide resolved
python/dask_cudf/setup.py Outdated Show resolved Hide resolved
python/dask_cudf/setup.py Outdated Show resolved Hide resolved
@github-actions github-actions bot added conda Python Affects Python cuDF API. labels Sep 23, 2021
jakirkham
jakirkham reviewed Sep 23, 2021
View reviewed changes
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Prem! 😄

Had a couple minor suggestions above

ci/gpu/build.sh Outdated Show resolved Hide resolved
ci/benchmark/build.sh Outdated Show resolved Hide resolved
galipremsagar
galipremsagar commented Sep 23, 2021
View reviewed changes
conda/environments/cudf_dev_cuda11.0.yml Outdated Show resolved Hide resolved
conda/environments/cudf_dev_cuda11.2.yml Outdated Show resolved Hide resolved
conda/recipes/custreamz/meta.yaml Outdated Show resolved Hide resolved
conda/recipes/dask-cudf/meta.yaml Outdated Show resolved Hide resolved
conda/recipes/dask-cudf/meta.yaml Outdated Show resolved Hide resolved
python/custreamz/dev_requirements.txt Outdated Show resolved Hide resolved
python/dask_cudf/dev_requirements.txt Outdated Show resolved Hide resolved
python/dask_cudf/setup.py Outdated Show resolved Hide resolved
python/dask_cudf/setup.py Outdated Show resolved Hide resolved
@galipremsagar galipremsagar mentioned this pull request Sep 23, 2021
Merged
@galipremsagar
Copy link
Contributor Author

rerun tests

rapids-bot bot pushed a commit to rapidsai/dask-cuda that referenced this pull request Sep 23, 2021
@galipremsagar
Pin max dask and distributed versions to 2021.09.1 (#735)
5abd4dd 
Changes to be in-line with: rapidsai/cudf#9286

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Peter Andreas Entschev (https://github.com/pentschev)

URL: #735
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Sep 23, 2021
rapids-bot bot pushed a commit to rapidsai/raft that referenced this pull request Sep 23, 2021
@galipremsagar
Pin max dask and distributed versions to 2021.09.1 (#334)
2ecb227 
Changes to be in-line with: rapidsai/cudf#9286

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: #334
rapids-bot bot pushed a commit to rapidsai/cuml that referenced this pull request Sep 23, 2021
@galipremsagar
Pin max dask and distributed versions to 2021.09.1 (#4229)
a69db68 
Changes to be in-line with: rapidsai/cudf#9286

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: #4229
@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 15a7dcc into rapidsai:branch-21.10 Sep 23, 2021
rapids-bot bot pushed a commit to rapidsai/cugraph that referenced this pull request Sep 24, 2021
@galipremsagar
Pin max dask and distributed versions to 2021.09.1 (#1841)
c41ffd4 
Changes to be in-line with: rapidsai/cudf#9286

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: #1841
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@galipremsagar
Pin max dask and distributed versions to 2021.09.1 (rapidsai#4229)
e9e71e1 
Changes to be in-line with: rapidsai/cudf#9286

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4229
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakirkham jakirkham jakirkham approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@brandon-b-miller brandon-b-miller brandon-b-miller approved these changes

@charlesbluca charlesbluca Awaiting requested review from charlesbluca

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@galipremsagar @jakirkham @ajschmidt8 @brandon-b-miller