Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Upgrade clang to 11.1.0 #9716

Merged
merged 4 commits into from
Nov 18, 2021

Conversation

galipremsagar
Copy link
Contributor

This PR upgrades clang to 11.1.0. The version upgrade is required because, clang-11=11.0.0 needs libclang-cpp11-11.0.0 which needs libllvm11=11.0.1 only. But for #9687 to work, numba-0.54 has to be installed which needs llvmlite 0.37.* which requires libllvm11 >=11.1.0,<11.2.0a0

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 17, 2021
@galipremsagar galipremsagar requested review from a team as code owners November 17, 2021 15:25
@galipremsagar galipremsagar self-assigned this Nov 17, 2021
@galipremsagar galipremsagar requested review from mythrocks and nvdbaranec and removed request for a team November 17, 2021 15:25
@github-actions github-actions bot added conda libcudf Affects libcudf (C++/CUDA) code. labels Nov 17, 2021
@galipremsagar
Copy link
Contributor Author

rerun tests

1 similar comment
@quasiben
Copy link
Member

rerun tests

@quasiben
Copy link
Member

rerun tests

2 similar comments
@quasiben
Copy link
Member

rerun tests

@galipremsagar
Copy link
Contributor Author

rerun tests

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Nov 18, 2021
@quasiben
Copy link
Member

rerun tests

@galipremsagar
Copy link
Contributor Author

rerun tests

rapids-bot bot pushed a commit to rapidsai/cugraph that referenced this pull request Nov 18, 2021
This upgrade is required to be in-line with: rapidsai/cudf#9716

Depends on: rapidsai/integration#390

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)
  - Brad Rees (https://github.com/BradReesWork)

URL: #1949
rapids-bot bot pushed a commit to rapidsai/cuml that referenced this pull request Nov 18, 2021
This upgrade is required to be in-line with: rapidsai/cudf#9716

Depends on: rapidsai/integration#390

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)
  - Ray Douglass (https://github.com/raydouglass)

URL: #4372
@jakirkham
Copy link
Member

rerun tests

@galipremsagar galipremsagar requested a review from a team as a code owner November 18, 2021 19:23
@galipremsagar galipremsagar requested review from trxcllnt and cwharris and removed request for a team November 18, 2021 19:23
@ajschmidt8 ajschmidt8 merged commit 012bfe9 into rapidsai:branch-21.12 Nov 18, 2021
@karthikeyann
Copy link
Contributor

karthikeyann commented Nov 18, 2021

Is this merged to branch-22.02 as well?

@galipremsagar
Copy link
Contributor Author

galipremsagar commented Nov 18, 2021

Is this merged to branch-22.02 as well?

Yes, will be merged with #9721

ajschmidt8 pushed a commit to rapidsai/raft that referenced this pull request Nov 22, 2021
This PR upgrades clang to `11.1.0` which is similar to: rapidsai/cudf#9716
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
This upgrade is required to be in-line with: rapidsai/cudf#9716

Depends on: rapidsai/integration#390

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)
  - Ray Douglass (https://github.com/raydouglass)

URL: rapidsai#4372
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants