Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete CUDA_ARCHITECTURES=OFF #1638

Merged
merged 1 commit into from
Jun 1, 2021

Conversation

seunghwak
Copy link
Contributor

set_target_properties(cugraphmgtestutil PROPERTIES CUDA_ARCHITECTURES OFF) was set and this caused cudaFuncGetAttribute to intermittently return an invalid PTX version. This PR deletes this.

@seunghwak seunghwak requested a review from a team as a code owner June 1, 2021 14:23
@seunghwak seunghwak added 3 - Ready for Review bug Something isn't working non-breaking Non-breaking change labels Jun 1, 2021
@BradReesWork BradReesWork added this to the 21.06 milestone Jun 1, 2021
@seunghwak seunghwak mentioned this pull request Jun 1, 2021
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not CMake savvy, so I'll defer to the other reviewers here.

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 45a50aa into rapidsai:branch-21.06 Jun 1, 2021
@seunghwak seunghwak deleted the bug_tests_cmake branch June 24, 2021 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants