Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose epsilon parameter (precision) through python layer #1674

Merged

Conversation

ChuckHastings
Copy link
Collaborator

Completes the work of exposing the precision parameter to the caller in python as requested by #1645

Fixes a few PR comments from PR #1673 that were deferred as that PR required merging to fix the build.

@ChuckHastings ChuckHastings requested review from a team as code owners June 16, 2021 17:55
@ChuckHastings ChuckHastings self-assigned this Jun 16, 2021
@ChuckHastings ChuckHastings added 3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 16, 2021
@ChuckHastings ChuckHastings added this to the 21.08 milestone Jun 16, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@1030a49). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 663f52f differs from pull request most recent head a4a7d6f. Consider uploading reports for the commit a4a7d6f to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #1674   +/-   ##
===============================================
  Coverage                ?   59.79%           
===============================================
  Files                   ?       80           
  Lines                   ?     3542           
  Branches                ?        0           
===============================================
  Hits                    ?     2118           
  Misses                  ?     1424           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1030a49...a4a7d6f. Read the comment docs.

Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 7119b2f into rapidsai:branch-21.08 Jun 18, 2021
@ChuckHastings ChuckHastings deleted the fea_expose_epsilon_python branch July 29, 2021 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants