Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] CHECK_CUDA macros in debug builds #1687

Merged
merged 3 commits into from
Jun 28, 2021
Merged

[FIX] CHECK_CUDA macros in debug builds #1687

merged 3 commits into from
Jun 28, 2021

Conversation

trxcllnt
Copy link
Collaborator

No description provided.

@trxcllnt trxcllnt requested a review from a team as a code owner June 24, 2021 21:11
@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2021 •
edited
Loading

Codecov Report

Merging #1687 (ac412b4) into branch-21.08 (0cbbdd8) will increase coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.08    #1687      +/-   ##
================================================
+ Coverage         59.77%   59.99%   +0.22%     
================================================
  Files                80       80              
  Lines              3540     3542       +2     
================================================
+ Hits               2116     2125       +9     
+ Misses             1424     1417       -7
Impacted Files Coverage Δ
python/cugraph/_version.py 44.80% <0.00%> (+0.39%) ⬆️
python/cugraph/utilities/utils.py 74.46% <0.00%> (+1.41%) ⬆️
python/cugraph/structure/number_map.py 67.05% <0.00%> (+1.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cbbdd8...ac412b4. Read the comment docs.

@BradReesWork BradReesWork added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change 3 - Ready for Review labels Jun 25, 2021
@BradReesWork BradReesWork added this to the 21.08 milestone Jun 25, 2021
seunghwak
seunghwak approved these changes Jun 25, 2021
View reviewed changes
Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're switching from cudaStream_t to rmm::cuda_stream_view, so I think we need to eventually update CHECK_CUDA to take rmm::cuda_stream_view, but at this moment, this looks like a proper fix.

kaatish
kaatish approved these changes Jun 25, 2021
View reviewed changes
Copy link
Collaborator

@kaatish kaatish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit f714e3e into rapidsai:branch-21.08 Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaatish kaatish kaatish approved these changes

@ChuckHastings ChuckHastings ChuckHastings approved these changes

@seunghwak seunghwak seunghwak approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
21.08
Development

Successfully merging this pull request may close these issues.
6 participants
@trxcllnt @codecov-commenter @BradReesWork @kaatish @ChuckHastings @seunghwak