Move legacy implementations into legacy directories #1752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChuckHastings
added
3 - Ready for Review
improvement
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #1752 +/- ##
===============================================
Coverage ? 59.75%
===============================================
Files ? 77
Lines ? 3523
Branches ? 0
===============================================
Hits ? 2105
Misses ? 1418
Partials ? 0 Continue to review full report at Codecov.
|
seunghwak
approved these changes
Aug 4, 2021
I think in one of my previous tries at this I tried deleting some of these things. I believe katz_centrality was one of the things that I could delete. I'll test that out on my next PR and delete what I can. |
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is phase 1 of the plan to move the now
non-experimentalthings in the experimental namespace into thecugraphnamespace. Unfortunately, some of the legacy implementations are still required, so we're going to move the files into legacy directories so they can be removed later.NOTE: This is not moving everything that is legacy into legacy directories. Only things that are in the way of new things or were in the same directories as things that were in the way of new things. We will move other things into legacy directories when/if needed.