Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++ benchmarking for additional algorithms #1762

Merged
merged 7 commits into from
Aug 6, 2021
Merged

C++ benchmarking for additional algorithms #1762

merged 7 commits into from
Aug 6, 2021

Conversation

seunghwak
Copy link
Contributor

@seunghwak seunghwak commented Aug 5, 2021 •
edited
Loading

Apply the updates in PR #1755 (for MG PageRank) to

MG: Katz Centrality, BFS, SSSP, WCC, and primitive tests
SG: PageRank, Katz Centrality, BFS, SSSP, and WCC tests

@ChuckHastings I will defer Louvain test updates to you :-) once Louvain tests get updated to take R-mat graphs.

@seunghwak seunghwak requested a review from a team as a code owner August 5, 2021 20:50
@seunghwak seunghwak changed the title [WIP] C++ benchmakring [WIP][skip-ci] C++ benchmakring Aug 5, 2021
@seunghwak seunghwak added 2 - In Progress non-breaking Non-breaking change feature request New feature or request labels Aug 5, 2021
rlratzel
rlratzel approved these changes Aug 6, 2021
View reviewed changes
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thank you. I think the new name expresses the intent better and the comments will prevent surprises to future maintainers. 👍

@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@0fb1724). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 7929b8b differs from pull request most recent head 6eb9d14. Consider uploading reports for the commit 6eb9d14 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #1762   +/-   ##
===============================================
  Coverage                ?   59.72%           
===============================================
  Files                   ?       77           
  Lines                   ?     3521           
  Branches                ?        0           
===============================================
  Hits                    ?     2103           
  Misses                  ?     1418           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fb1724...6eb9d14. Read the comment docs.

@seunghwak seunghwak changed the title [WIP][skip-ci] C++ benchmakring C++ benchmakring for additional algorithms Aug 6, 2021
@seunghwak
Copy link
Contributor Author

rerun tests

@seunghwak seunghwak changed the title C++ benchmakring for additional algorithms C++ benchmarking for additional algorithms Aug 6, 2021
ChuckHastings
ChuckHastings reviewed Aug 6, 2021
View reviewed changes
Copy link
Collaborator

@ChuckHastings ChuckHastings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

cpp/tests/traversal/legacy/sssp_test.cu Outdated
// iterations for perf tests

// enabled by command line parameter '--perf-iters"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is no longer true, correct? Probably should at least delete the comment if we want to leave in the run 5 times logic.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, and done.

cpp/tests/layout/force_atlas2_test.cu Outdated Show resolved Hide resolved
@ChuckHastings
Copy link
Collaborator

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 009b53b into rapidsai:branch-21.10 Aug 6, 2021
@seunghwak seunghwak deleted the fea_cpp_benchmark2 branch October 19, 2021 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlratzel rlratzel rlratzel approved these changes

@ChuckHastings ChuckHastings ChuckHastings approved these changes

@kaatish kaatish Awaiting requested review from kaatish

Assignees
No one assigned
Labels
feature request New feature or request non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seunghwak @codecov-commenter @ChuckHastings @rlratzel