Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating WCC/SCC notebook #1893

Merged
merged 2 commits into from
Oct 26, 2021
Merged

Updating WCC/SCC notebook #1893

merged 2 commits into from
Oct 26, 2021

Conversation

BradReesWork
Copy link
Member

The WCC/SCC was old and examples did not consider renumbering

@BradReesWork BradReesWork added 3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 18, 2021
@BradReesWork BradReesWork added this to the 21.12 milestone Oct 18, 2021
@BradReesWork BradReesWork self-assigned this Oct 18, 2021
@BradReesWork BradReesWork requested a review from a team as a code owner October 18, 2021 19:42
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@BradReesWork BradReesWork linked an issue Oct 18, 2021 that may be closed by this pull request
[BUG]Connected Components Notebook's "Strongly Connected Component" is NOT a strongly connected component and returns an empty dataframe #1887
Closed
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.12@33361d0). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 8b70f68 differs from pull request most recent head 3ac4471. Consider uploading reports for the commit 3ac4471 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.12    #1893   +/-   ##
===============================================
  Coverage                ?   69.48%           
===============================================
  Files                   ?      143           
  Lines                   ?     8631           
  Branches                ?        0           
===============================================
  Hits                    ?     5997           
  Misses                  ?     2634           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33361d0...3ac4471. Read the comment docs.

taureandyernv
taureandyernv approved these changes Oct 21, 2021
View reviewed changes
Copy link

@taureandyernv taureandyernv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in testing! Thanks Brad!

@BradReesWork
Copy link
Member Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit a862746 into rapidsai:branch-21.12 Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlratzel rlratzel rlratzel approved these changes

@taureandyernv taureandyernv taureandyernv approved these changes

Assignees

@BradReesWork BradReesWork

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
21.12
4 participants
@BradReesWork @codecov-commenter @rlratzel @taureandyernv