Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve MG Louvain scalability #2062

Merged
merged 92 commits into from
Mar 9, 2022
Merged

Improve MG Louvain scalability #2062

merged 92 commits into from
Mar 9, 2022

Conversation

seunghwak
Copy link
Contributor

@seunghwak seunghwak commented Feb 7, 2022 •
edited
Loading

Pulls updates from PRs #2044, better be reviewed and merged after PR #2044

Mainly experimenting, not ready for review.

@seunghwak
update group_by_and_count to not use reduce_by_key (which is expensiv…
6102cd1 
…e and also seems like having an issue with 2^31 or more elements)
@seunghwak
add time measurements (should be undone)
5146b19
@seunghwak
Merge branch 'branch-22.04' of github.com:rapidsai/cugraph into enh_g…
5073304 
…raph_creation
@seunghwak
improve weak scaling behavior of renumber
7c02fcf
@seunghwak
move is_first_in_run_t to graph_utils.cuh
0744160
@seunghwak
avoid using device lambdas
077008b
@seunghwak
fix compile errors
6a0dfa1
@seunghwak
code cleanup
41645aa
@seunghwak
fix overflow bug with 2^31 or more vertices
a0b009e
@seunghwak
Merge branch 'branch-22.04' of github.com:rapidsai/cugraph into enh_g…
b5cb9c4 
…raph_creation
@seunghwak
delete temporary performance measurement code
9a70472
@seunghwak
delete additional temporary performance measurement code
214ada9
@seunghwak
remove temporary performance measurement code
3a605b5
@seunghwak
Merge branch 'branch-22.04' of github.com:rapidsai/cugraph into enh_g…
c537e2d 
…raph_creation
@seunghwak
clang-format & copyright year
4852ce4
@seunghwak
release no-longer necessary memory earlier to reclaim
d8ba3ed
@seunghwak
bug fix in MG C++ R-mat test input graph generation parameters
ee815ae
@seunghwak
clang-format & copyright
9518b8b
@seunghwak
add temporary performance measurements
e0cd4af
@seunghwak
add more temporary measurement code
a7b8690
@seunghwak
resolve merge conflicts
213e80d
@seunghwak
add access functions to key_data in minor_properties_device_view_t
0cd1574
@seunghwak
mionr cosmetic fix
e629e5d
@seunghwak
reduce peak memory consumption & communication volume in copy_v_trans…
0d18c28 
…form_reduce_key_aggregated_out_nbr
@seunghwak seunghwak added 2 - In Progress improvement Improvement / enhancement to an existing function DO NOT MERGE Hold off on merging; see PR for details non-breaking Non-breaking change labels Feb 7, 2022
@seunghwak
additioal copy_v_transform_reduce_key_aggregated_out_nbr peak memory …
d71c856 
…tuning
@seunghwak
fix for a possible hang
ff12636
@seunghwak
Merge branch 'upstream_pr2081' into enh_mg_louvain
703b120
@seunghwak
replace the default constructor of row/col_properties_t with the one …
3a4b26e 
…taking a handle object and add clear()
@seunghwak
clean-up collect_values_for_unique_keys
1ff8d92
@seunghwak
release memory in adj_matrix_minor_labels ASAP
a4f3b40
@seunghwak
lower peak memory in copy_v_transform_reduce_key_aggregated_out_nbr
dc6762d
@seunghwak
resolve merge conflicts
1692a46
@seunghwak
additional cut in peak memory and maximum single allocation size (to …
b1e56e7 
…avoid malloc failure due to fragmentation with the pool allocator)
@seunghwak
resolve merge conflicts
dbec02a
@seunghwak
resolve merge conflicts
9178da4
@seunghwak
fix error in resolving merge conflicts
17cbde4
@seunghwak
remove temporary performance measurement code
24f7cbd
@seunghwak seunghwak changed the title [WIP][skip-ci] Improve MG Louvain scalability Improve MG Louvain scalability Mar 9, 2022
@seunghwak seunghwak added 3 - Ready for Review and removed 2 - In Progress DO NOT MERGE Hold off on merging; see PR for details labels Mar 9, 2022
@seunghwak seunghwak marked this pull request as ready for review March 9, 2022 00:18
@seunghwak seunghwak requested a review from a team as a code owner March 9, 2022 00:18
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.04@93dba00). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.04    #2062   +/-   ##
===============================================
  Coverage                ?   73.63%           
===============================================
  Files                   ?      154           
  Lines                   ?    10327           
  Branches                ?        0           
===============================================
  Hits                    ?     7604           
  Misses                  ?     2723           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93dba00...dc33a11. Read the comment docs.

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit ab72ed5 into rapidsai:branch-22.04 Mar 9, 2022
@seunghwak seunghwak deleted the enh_mg_louvain branch August 11, 2022 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChuckHastings ChuckHastings ChuckHastings approved these changes

@kaatish kaatish Awaiting requested review from kaatish

Assignees

@seunghwak seunghwak

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
22.04
Development

Successfully merging this pull request may close these issues.
4 participants
@seunghwak @codecov-commenter @BradReesWork @ChuckHastings