Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused code (gunrock HITS) #2152

Merged
merged 3 commits into from
Apr 6, 2022

Conversation

seunghwak
Copy link
Contributor

Delete no-longer-used code

@seunghwak seunghwak added 3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 23, 2022
@seunghwak seunghwak added this to the 22.06 milestone Mar 23, 2022
@seunghwak seunghwak requested a review from a team as a code owner March 23, 2022 17:56
@seunghwak seunghwak self-assigned this Mar 30, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2022

Codecov Report

Merging #2152 (6fdfb99) into branch-22.06 (017baab) will decrease coverage by 3.00%.
The diff coverage is 61.25%.

❗ Current head 6fdfb99 differs from pull request most recent head e710794. Consider uploading reports for the commit e710794 to get more accurate results

@@               Coverage Diff                @@
##           branch-22.06    #2152      +/-   ##
================================================
- Coverage         72.41%   69.40%   -3.01%     
================================================
  Files               157      170      +13     
  Lines             10496    11036     +540     
================================================
+ Hits               7601     7660      +59     
- Misses             2895     3376     +481     
Impacted Files Coverage Δ
...aph/cugraph/dask/sampling/neighborhood_sampling.py 0.00% <0.00%> (ø)
.../cugraph/cugraph/experimental/compat/nx/DiGraph.py 0.00% <0.00%> (ø)
...on/cugraph/cugraph/experimental/compat/nx/Graph.py 0.00% <0.00%> (ø)
...thon/cugraph/cugraph/experimental/dask/__init__.py 0.00% <0.00%> (ø)
python/cugraph/cugraph/tests/dask/test_mg_hits.py 0.00% <0.00%> (ø)
...ugraph/tests/dask/test_mg_neighborhood_sampling.py 0.00% <0.00%> (ø)
.../cugraph/cugraph/tests/dask/test_mg_replication.py 0.00% <0.00%> (-33.34%) ⬇️
python/cugraph/cugraph/dask/link_analysis/hits.py 18.36% <18.36%> (ø)
...h/pylibcugraph/tests/test_neighborhood_sampling.py 20.83% <20.83%> (ø)
python/cugraph/cugraph/sampling/node2vec.py 81.81% <69.23%> (-9.30%) ⬇️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 017baab...e710794. Read the comment docs.

@ChuckHastings
Copy link
Collaborator

rerun tests

1 similar comment
@BradReesWork
Copy link
Member

rerun tests

@BradReesWork
Copy link
Member

rerun tests

@ChuckHastings
Copy link
Collaborator

@gpucibot merge

@rapids-bot rapids-bot bot merged commit af7e935 into rapidsai:branch-22.06 Apr 6, 2022
@seunghwak seunghwak deleted the enh_dead_code branch August 11, 2022 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants