Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update graph/graph primitives API to consistently use vertex/edge centric terminologies instead of matrix centric terminolgies #2187

Merged
merged 18 commits into from
Apr 7, 2022

Conversation

seunghwak
Copy link
Contributor

Partially address #2003

cuGrpah public API has been mixing vertex/edge-centric terminologies and vector/matrix-centric terminologies.

  • matrix_partition => edge_partition
  • row => source (src), column (col) => destination (dst)
  • rename get_property_name() functions to property_name() for brevity and better follow naming conventions for C++ standard library
  • other updates to better group/clarify vertex/edge partition related functions.

@seunghwak seunghwak requested a review from a team as a code owner April 4, 2022 16:53
@seunghwak seunghwak self-assigned this Apr 4, 2022
@seunghwak seunghwak added 2 - In Progress improvement Improvement / enhancement to an existing function breaking Breaking change labels Apr 4, 2022
@seunghwak seunghwak added this to the 22.06 milestone Apr 4, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2022

Codecov Report

Merging #2187 (f4fe1a6) into branch-22.06 (9956084) will increase coverage by 0.04%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           branch-22.06    #2187      +/-   ##
================================================
+ Coverage         70.82%   70.86%   +0.04%     
================================================
  Files               170      170              
  Lines             11036    11036              
================================================
+ Hits               7816     7821       +5     
+ Misses             3220     3215       -5     
Impacted Files Coverage Δ
.../cugraph/tests/test_edge_betweenness_centrality.py 84.93% <0.00%> (+0.60%) ⬆️
...graph/cugraph/tests/test_betweenness_centrality.py 83.01% <0.00%> (+0.62%) ⬆️
python/cugraph/cugraph/tests/test_graph_store.py 100.00% <0.00%> (+1.56%) ⬆️
python/cugraph/cugraph/tests/test_utils.py 75.55% <0.00%> (+4.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9956084...f4fe1a6. Read the comment docs.

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit f545fa5 into rapidsai:branch-22.06 Apr 7, 2022
@seunghwak seunghwak deleted the enh_graph_view branch August 11, 2022 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change improvement Improvement / enhancement to an existing function
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants