Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MG Hits and MG Neighborhood_sampling to benchmarks #2254

Conversation

jnke2016
Copy link
Contributor

This PR

  1. Adds MG Hits and MG Neighborhood sampling to our list of algos to benchmarks in the nightlies
  2. Drops the legacy renumbering not needed in the C/Pylibcugraph path

@jnke2016 jnke2016 marked this pull request as draft April 28, 2022 19:49
@rlratzel rlratzel added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python labels Apr 30, 2022
@rlratzel rlratzel added this to the 22.06 milestone Apr 30, 2022
@jnke2016 jnke2016 marked this pull request as ready for review May 5, 2022 14:20
@jnke2016 jnke2016 requested a review from a team as a code owner May 5, 2022 14:20
@codecov-commenter
Copy link

codecov-commenter commented May 5, 2022

Codecov Report

Merging #2254 (93c88e1) into branch-22.06 (3506893) will decrease coverage by 2.86%.
The diff coverage is 56.77%.

❗ Current head 93c88e1 differs from pull request most recent head 445d019. Consider uploading reports for the commit 445d019 to get more accurate results

@@               Coverage Diff                @@
##           branch-22.06    #2254      +/-   ##
================================================
- Coverage         72.77%   69.90%   -2.87%     
================================================
  Files               173      175       +2     
  Lines             11423    11517      +94     
================================================
- Hits               8313     8051     -262     
- Misses             3110     3466     +356     
Impacted Files Coverage Δ
python/cugraph/cugraph/__init__.py 100.00% <ø> (ø)
python/cugraph/cugraph/dask/link_analysis/hits.py 18.75% <0.00%> (+0.38%) ⬆️
...aph/cugraph/dask/sampling/neighborhood_sampling.py 0.00% <0.00%> (ø)
.../cugraph/tests/mg/test_mg_neighborhood_sampling.py 0.00% <ø> (-36.37%) ⬇️
python/cugraph/cugraph/structure/number_map.py 65.83% <10.52%> (-1.20%) ⬇️
...ure/graph_implementation/simpleDistributedGraph.py 23.02% <21.05%> (-0.17%) ⬇️
python/cugraph/cugraph/structure/symmetrize.py 58.92% <56.52%> (-6.53%) ⬇️
python/cugraph/cugraph/structure/graph_classes.py 78.46% <71.42%> (-0.08%) ⬇️
...on/cugraph/cugraph/centrality/degree_centrality.py 81.81% <81.81%> (ø)
...raph/structure/graph_implementation/simpleGraph.py 74.15% <90.00%> (-0.15%) ⬇️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3506893...445d019. Read the comment docs.

@rlratzel
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit d9ec8f7 into rapidsai:branch-22.06 May 17, 2022
alexbarghi-nv added a commit to alexbarghi-nv/cugraph that referenced this pull request May 17, 2022
Add MG Hits and MG Neighborhood_sampling to benchmarks (rapidsai#2254)
@jnke2016 jnke2016 deleted the branch-22.06-add_new_mg_algos_and_drop_legacy_renumbering branch September 24, 2022 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants