Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace clock_gettime with std::chrono::steady_clock #3049

Merged
merged 9 commits into from
Dec 15, 2022
Merged

Replace clock_gettime with std::chrono::steady_clock #3049

merged 9 commits into from
Dec 15, 2022

Conversation

seunghwak
Copy link
Contributor

  • Replace clock_gettime in HighResTimer with std::chrono::steady_clock in high_res_timer.hpp
  • Move high_res_timer.hpp from src/utilities to include/cugraph/utilities
  • Replace HighResClock (tests/utilities/high_res_clock.h) with HighResTimer

@seunghwak seunghwak self-assigned this Dec 6, 2022
@seunghwak seunghwak added 2 - In Progress non-breaking Non-breaking change labels Dec 6, 2022
@seunghwak seunghwak added this to the 23.02 milestone Dec 6, 2022
@seunghwak seunghwak changed the title [WIP][skip-ci] Replace clock_gettime with std::chrono::steady_clock Replace clock_gettime with std::chrono::steady_clock Dec 6, 2022
@seunghwak seunghwak marked this pull request as ready for review December 6, 2022 18:40
@seunghwak seunghwak requested a review from a team as a code owner December 6, 2022 18:40
@seunghwak seunghwak added 3 - Ready for Review improvement Improvement / enhancement to an existing function and removed 2 - In Progress labels Dec 6, 2022
@seunghwak
Copy link
Contributor Author

rerun tests

@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-23.02@efcf6a8). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 54eec66 differs from pull request most recent head bc35c53. Consider uploading reports for the commit bc35c53 to get more accurate results

Additional details and impacted files 
@@               Coverage Diff               @@
##             branch-23.02    #3049   +/-   ##
===============================================
  Coverage                ?   58.95%           
===============================================
  Files                   ?      131           
  Lines                   ?     7857           
  Branches                ?        0           
===============================================
  Hits                    ?     4632           
  Misses                  ?     3225           
  Partials                ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@seunghwak
Copy link
Contributor Author

rerun tests

@seunghwak seunghwak mentioned this pull request Dec 7, 2022
Merged
@seunghwak seunghwak mentioned this pull request Dec 8, 2022
Merged
@ChuckHastings ChuckHastings mentioned this pull request Dec 9, 2022
Closed
@rlratzel
Copy link
Contributor

rerun tests

reason: merged #3066 which should fix CI errors

@BradReesWork
Copy link
Member

rerun tests

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit c151bfb into rapidsai:branch-23.02 Dec 15, 2022
@seunghwak seunghwak deleted the fix_link_error branch May 5, 2023 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChuckHastings ChuckHastings ChuckHastings approved these changes

@naimnv naimnv naimnv approved these changes

@jnke2016 jnke2016 Awaiting requested review from jnke2016

Assignees

@seunghwak seunghwak

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
23.02
Development

Successfully merging this pull request may close these issues.
6 participants
@seunghwak @codecov-commenter @rlratzel @BradReesWork @ChuckHastings @naimnv