Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Actions Notebook Testing Fixes #3097

Merged
merged 2 commits into from
Jan 1, 2023

Conversation

ajschmidt8
Copy link
Member

This PR contains fixes for some things I missed in #3095.

Specifically:

  • Adds the conda-notebook-tests job as a dependency of the pr-builder job
  • Removes a duplicate notebook dependency from dependencies.yaml

@ajschmidt8 ajschmidt8 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 31, 2022
@ajschmidt8 ajschmidt8 requested a review from a team as a code owner December 31, 2022 17:15
@ajschmidt8
Copy link
Member Author

cc: @bdice

@codecov-commenter
Copy link

codecov-commenter commented Dec 31, 2022

Codecov Report

Base: 58.86% // Head: 57.18% // Decreases project coverage by -1.67% ⚠️

Coverage data is based on head (99a44b8) compared to base (2ae4b61).
Patch coverage: 46.70% of modified lines in pull request are covered.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-23.02    #3097      +/-   ##
================================================
- Coverage         58.86%   57.18%   -1.68%     
================================================
  Files               131      148      +17     
  Lines              7848     9292    +1444     
================================================
+ Hits               4620     5314     +694     
- Misses             3228     3978     +750     
Impacted Files Coverage Δ
...-service/server/cugraph_service_server/__main__.py 0.00% <0.00%> (ø)
...ure/graph_implementation/simpleDistributedGraph.py 14.45% <0.00%> (-0.45%) ⬇️
python/cugraph/cugraph/testing/utils.py 71.42% <ø> (-4.19%) ⬇️
...-service/server/cugraph_service_server/__init__.py 25.00% <14.28%> (ø)
python/cugraph/cugraph/testing/mg_utils.py 31.03% <31.03%> (ø)
...ugraph/cugraph/dask/structure/mg_property_graph.py 12.14% <33.33%> (+0.05%) ⬆️
...rvice_server/testing/benchmark_server_extension.py 40.38% <40.38%> (ø)
...vice/client/cugraph_service_client/remote_graph.py 43.75% <55.55%> (ø)
...e/server/cugraph_service_server/cugraph_handler.py 43.81% <70.31%> (ø)
...ice/server/cugraph_service_server/testing/utils.py 80.39% <80.00%> (ø)
... and 22 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ajschmidt8
Copy link
Member Author

@gpucibot merge

@ajschmidt8
Copy link
Member Author

ajschmidt8 commented Dec 31, 2022

Adds the conda-notebook-tests job as a dependency of the pr-builder job

FWIW, I opened a PR below to add a job to test this automatically since it's easy to forget. It works locally, just need to test it in a PR before we merge it.

@rapids-bot rapids-bot bot merged commit e8a9bf3 into rapidsai:branch-23.02 Jan 1, 2023
@ajschmidt8 ajschmidt8 deleted the gha-notebooks branch January 1, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants