Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop DiGraph #3126

Merged
merged 19 commits into from
Jan 12, 2023
Merged

Drop DiGraph #3126

merged 19 commits into from
Jan 12, 2023

Conversation

BradReesWork
Copy link
Member

@BradReesWork BradReesWork commented Jan 10, 2023 •
edited
Loading

this PR removes the DiGraph classes and all references to those classes from the code and tests.
All test are updated and validated.

DiGraph has been deprecated for over a year and it was time to finally remove it

closes #3136

@BradReesWork BradReesWork added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 10, 2023
@BradReesWork BradReesWork added this to the 23.02 milestone Jan 10, 2023
@BradReesWork BradReesWork self-assigned this Jan 10, 2023
@BradReesWork BradReesWork requested a review from a team as a code owner January 10, 2023 18:29
alexbarghi-nv
alexbarghi-nv requested changes Jan 10, 2023
View reviewed changes
Copy link
Member

@alexbarghi-nv alexbarghi-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just minor changes requested and one question

python/cugraph/cugraph/components/connectivity.py Outdated Show resolved Hide resolved
python/cugraph/cugraph/tests/test_balanced_cut.py Outdated Show resolved Hide resolved
python/cugraph/cugraph/tests/test_bfs.py Outdated Show resolved Hide resolved
python/cugraph/cugraph/tests/test_connectivity.py Outdated Show resolved Hide resolved
python/cugraph/cugraph/tests/test_connectivity.py Outdated Show resolved Hide resolved
python/cugraph/cugraph/tests/test_louvain.py Show resolved Hide resolved
python/cugraph/cugraph/tests/test_sssp.py Outdated Show resolved Hide resolved
python/cugraph/cugraph/traversal/bfs.py Outdated Show resolved Hide resolved
python/cugraph/cugraph/traversal/bfs.py Outdated Show resolved Hide resolved
python/cugraph/cugraph/traversal/sssp.py Outdated Show resolved Hide resolved
acostadon
acostadon approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@acostadon acostadon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

BradReesWork and others added 8 commits January 10, 2023 14:29
@BradReesWork @alexbarghi-nv
Update python/cugraph/cugraph/components/connectivity.py
682aba6 
Co-authored-by: Alex Barghi <105237337+alexbarghi-nv@users.noreply.github.com>
@BradReesWork @alexbarghi-nv
Update python/cugraph/cugraph/tests/test_bfs.py
2e741e8 
Co-authored-by: Alex Barghi <105237337+alexbarghi-nv@users.noreply.github.com>
@BradReesWork @alexbarghi-nv
Update python/cugraph/cugraph/tests/test_connectivity.py
291b5b9 
Co-authored-by: Alex Barghi <105237337+alexbarghi-nv@users.noreply.github.com>
@BradReesWork @alexbarghi-nv
Update python/cugraph/cugraph/tests/test_connectivity.py
4a2afe3 
Co-authored-by: Alex Barghi <105237337+alexbarghi-nv@users.noreply.github.com>
@BradReesWork @alexbarghi-nv
Update python/cugraph/cugraph/tests/test_sssp.py
dc46b3e 
Co-authored-by: Alex Barghi <105237337+alexbarghi-nv@users.noreply.github.com>
@BradReesWork @alexbarghi-nv
Update python/cugraph/cugraph/traversal/bfs.py
2180dd3 
Co-authored-by: Alex Barghi <105237337+alexbarghi-nv@users.noreply.github.com>
@BradReesWork @alexbarghi-nv
Update python/cugraph/cugraph/traversal/bfs.py
49186c3 
Co-authored-by: Alex Barghi <105237337+alexbarghi-nv@users.noreply.github.com>
@BradReesWork @alexbarghi-nv
Update python/cugraph/cugraph/traversal/sssp.py
c59d328 
Co-authored-by: Alex Barghi <105237337+alexbarghi-nv@users.noreply.github.com>
alexbarghi-nv
alexbarghi-nv approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@alexbarghi-nv alexbarghi-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alexbarghi-nv
Copy link
Member

/merge

acostadon
acostadon approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@acostadon acostadon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@BradReesWork BradReesWork mentioned this pull request Jan 11, 2023
Closed
24 tasks
@BradReesWork
Copy link
Member Author

rerun tests

@rapids-bot rapids-bot bot merged commit 73d5cc5 into rapidsai:branch-23.02 Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acostadon acostadon acostadon approved these changes

@alexbarghi-nv alexbarghi-nv alexbarghi-nv approved these changes

@rlratzel rlratzel Awaiting requested review from rlratzel

Assignees

@BradReesWork BradReesWork

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
23.02
Development

Successfully merging this pull request may close these issues.

[FEA]: Drop DiGraph
3 participants
@BradReesWork @alexbarghi-nv @acostadon