Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin to scikit-build<17.2 #3538

Merged
merged 1 commit into from
May 3, 2023
Merged

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented May 3, 2023

The latest scikit-build version breaks rapids-cython

@vyasr vyasr added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 3, 2023
@vyasr vyasr self-assigned this May 3, 2023
@vyasr vyasr requested review from a team as code owners May 3, 2023 18:33
@vyasr vyasr added bug Something isn't working and removed improvement Improvement / enhancement to an existing function labels May 3, 2023
Copy link
Member

@alexbarghi-nv alexbarghi-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexbarghi-nv
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 328dd26 into rapidsai:branch-23.06 May 3, 2023
@vyasr vyasr deleted the fix/pin_skbuild branch May 3, 2023 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants