Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin scikit-build upper bound #3609

Merged
merged 2 commits into from
Jun 8, 2023
Merged

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented May 24, 2023

Remove scikit-build upper bound pinning

@vyasr vyasr requested review from a team as code owners May 24, 2023 19:11
@vyasr vyasr added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 24, 2023
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some of the version strings in this PR were inadvertently changed back to 23.6

@BradReesWork BradReesWork added this to the 23.08 milestone May 24, 2023
@rlratzel
Copy link
Contributor

Oops, I approved before noticing what AJ mentioned. I'll leave it approved assuming AJ's comment is resolved.

@vyasr
Copy link
Contributor Author

vyasr commented May 30, 2023

It looks like dependencies.yaml is out of date. I assume that means something is wrong with update-version.sh.

@vyasr
Copy link
Contributor Author

vyasr commented Jun 8, 2023

/merge

@rapids-bot rapids-bot bot merged commit 2d4e2a7 into rapidsai:branch-23.08 Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants