Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

force atlas notebook changes to run in cugraph 23.08 container. #3656

Merged
merged 16 commits into from
Jul 24, 2023
Merged

force atlas notebook changes to run in cugraph 23.08 container. #3656

merged 16 commits into from
Jul 24, 2023

Conversation

acostadon
Copy link
Contributor

@acostadon acostadon commented Jun 12, 2023 •
edited
Loading

changes to allow for libary dependence on no longer supported numpy functions.
Also addresses notebook's need for cuxfilter.

resolves #3653

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@acostadon acostadon self-assigned this Jun 12, 2023
@acostadon acostadon added bug Something isn't working non-breaking Non-breaking change labels Jun 12, 2023
@acostadon acostadon added this to the 23.08 milestone Jun 12, 2023
@acostadon acostadon marked this pull request as ready for review June 22, 2023 18:39
@acostadon acostadon requested a review from a team as a code owner June 22, 2023 18:39
@BradReesWork
Copy link
Member

You need either a note that this notebook only running in the rapids docker container or provide a list of how to install the needed packages

BradReesWork
BradReesWork requested changes Jun 27, 2023
View reviewed changes
Copy link
Member

@BradReesWork BradReesWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update install notes

@rlratzel
Copy link
Contributor

force atlas notebook changes to run in cugraph 23.08 container

Which container (RAPIDS runtime, DLFW, etc.)? Can that be mentioned somewhere?

@rlratzel
Copy link
Contributor

rlratzel commented Jul 13, 2023 •
edited
Loading

I tried to review but GH gave this message:
"296 additions, 30 deletions not shown because the diff is too large. Please use a local Git client to view these changes. "

I'm curious why the diff was so large and how many changes were required to get this NB to run in the container environment you're using. Can you maybe update this PR description to summarize the changes? (looks like the description needs updating anyway since it mentions filing an issue, and has a "resolves" for itself :) )

@acostadon acostadon requested a review from rlratzel July 19, 2023 17:33
@BradReesWork
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit e437aa0 into rapidsai:branch-23.08 Jul 24, 2023
51 checks passed
@BradReesWork BradReesWork mentioned this pull request Jul 25, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BradReesWork BradReesWork BradReesWork approved these changes

@rlratzel rlratzel Awaiting requested review from rlratzel

Assignees

@acostadon acostadon

Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Milestone
23.08
Development

Successfully merging this pull request may close these issues.

Fix Force Atlas 2 notebook error
3 participants
@acostadon @BradReesWork @rlratzel