Adding metadata getter methods to datasets API #3821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nv-rliu
added
feature request
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/merge |
rlratzel
reviewed
Sep 8, 2023
Comment on lines
+331
to
+338
| @pytest.mark.parametrize("dataset", ALL_DATASETS) | ||
| def test_object_getters(dataset): | ||
| assert dataset.is_directed() == dataset.metadata["is_directed"] | ||
| assert dataset.is_multigraph() == dataset.metadata["is_multigraph"] | ||
| assert dataset.is_symmetric() == dataset.metadata["is_symmetric"] | ||
| assert dataset.number_of_nodes() == dataset.metadata["number_of_nodes"] | ||
| assert dataset.number_of_vertices() == dataset.metadata["number_of_nodes"] | ||
| assert dataset.number_of_edges() == dataset.metadata["number_of_edges"] |
There was a problem hiding this comment.
This really isn't testing much more than if the APIs are returning the metadata dict, and could start failing if we ever intentionally change the implementation to return something that's still valid but doesn't match the metadata dict exactly.
A better test would be if you verified is_directed and others are actually True or False based on if the datasets are directed or not, etc.
rlratzel
pushed a commit
to rlratzel/cugraph
that referenced
this pull request
Sep 8, 2023
Closes rapidsai#3820 This PR adds simple getter methods to the `dataset` class, which allows users to easily get information about datasets without need to access the `metadata` dict or look in the directory. ```python from cugraph.datasets import karate # users now call karate.number_of_nodes() # instead of karate.metadata['number_of_nodes'] ``` Authors: - ralph (https://github.com/nv-rliu) Approvers: - Alex Barghi (https://github.com/alexbarghi-nv) URL: rapidsai#3821
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3820
This PR adds simple getter methods to the
datasetclass, which allows users to easily get information about datasets without need to access themetadatadict or look in the directory.