Trim trailing whitespace #4206
Merged
Trim trailing whitespace #4206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should wait for #4205 to avoid conflicts. I'll mark this as |
|
Wonder if we should add the final commit produced by merging this PR to That could help keep the line noise down when reviewing https://github.blog/changelog/2022-03-24-ignore-commits-in-the-blame-view-beta/ |
BradReesWork
approved these changes
Feb 29, 2024
BradReesWork
added
improvement
AyodeAwe
approved these changes
Feb 29, 2024
|
/merge |
I think +/- 700 lines isn't enough to bother. There are larger PRs than this on a frequent basis. But feel free to file a follow-up PR after this merges and the commit hash is known, if you would like. (Maybe include #4205, too.) |
ChuckHastings
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR trims trailing whitespace and normalizes file endings in all files, and adds pre-commit hooks to enforce this for future contributions.
These pre-commit hooks already exist in most other RAPIDS repositories, so it would be good to standardize.