Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of sentinel namespace #4274

Merged
merged 6 commits into from
Apr 17, 2024
Merged

Get rid of sentinel namespace #4274

merged 6 commits into from
Apr 17, 2024

Conversation

PointKernel
Copy link
Member

This PR gets rid of the use of the deprecated cuco::sentinel inline namespace.

It's required to bump the cuco version in rapidsai/rapids-cmake#569

@PointKernel PointKernel requested a review from a team as a code owner March 24, 2024 22:16
seunghwak
seunghwak approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PointKernel
Copy link
Member Author

@seunghwak Could you merge the PR? Thanks!

@vyasr vyasr added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Apr 17, 2024
@vyasr
Copy link
Contributor

vyasr commented Apr 17, 2024

/merge

@rapids-bot rapids-bot bot merged commit 45d0126 into rapidsai:branch-24.06 Apr 17, 2024
131 checks passed
@PointKernel PointKernel deleted the remove-sentinel-namespace branch April 17, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seunghwak seunghwak seunghwak approved these changes

Assignees
No one assigned
Labels
cuGraph improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PointKernel @vyasr @seunghwak