Refactor CMakeLists.txt to better express usage requirements #4309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
approved these changes
Apr 4, 2024
There was a problem hiding this comment.
Thanks for doing this Robert! I can rebase the wheels work on this once it's merged and it should help clean up quite a few things. Also, removing the unnecessary NCCL linkage from the library should substantially reduce the wheel sizes in #4297, which is exciting. I have a few questions here but nothing blocking, feel free to resolve as you see fit and then merge.
vyasr
reviewed
Apr 4, 2024
bdice
approved these changes
Apr 4, 2024
|
/merge |
ChuckHastings
approved these changes
Apr 15, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the cugraph CMakeLists.txt genernated non-relocatable targets due to embedding absolute paths to RAFT and the CUDAToolkit. While refactoring those issues out I also made a general cleanup pass over the rest of the CMake code.