Skip to content
This repository has been archived by the owner on Sep 25, 2023. It is now read-only.

Add option for smaller dataset in IO notebook #473

Merged
merged 3 commits into from
Nov 21, 2022

Conversation

charlesbluca
Copy link
Member

@charlesbluca charlesbluca commented Apr 5, 2022

Adds the option to use a smaller ~300MB SigMF dataset for the IO examples, as well as code to automatically download / extract the dataset of choice.

Note that there are some failures in the notebook - raised #474 to cover this.

Closes #472

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added the Python label Apr 5, 2022
@github-actions
Copy link

github-actions bot commented May 6, 2022

This PR has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates. This PR will be labeled inactive-90d if there is no activity in the next 60 days.

@charlesbluca
Copy link
Member Author

@awthomp is this good to merge or would you like additional changes?

@awthomp
Copy link
Member

awthomp commented May 25, 2022

@charlesbluca LGTM

@charlesbluca
Copy link
Member Author

Ah I just noticed that I should rerun the cells with ValueErrors now that the pinned buffer issues have been resolved - will do that then this should be good to merge

@charlesbluca
Copy link
Member Author

Sorry for the delay - this should be good to merge now

@github-actions
Copy link

This PR has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates. This PR will be labeled inactive-90d if there is no activity in the next 60 days.

@charlesbluca charlesbluca changed the base branch from branch-22.06 to branch-22.08 July 28, 2022 14:34
@awthomp awthomp changed the base branch from branch-22.08 to branch-22.12 November 21, 2022 19:38
@awthomp awthomp added improvement Improvement / enhancement to an existing function and removed inactive-30d labels Nov 21, 2022
@awthomp awthomp added the non-breaking Non-breaking change label Nov 21, 2022
@awthomp
Copy link
Member

awthomp commented Nov 21, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 4de4081 into rapidsai:branch-22.12 Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Incorrect dataset specified in io_examples.ipynb
2 participants