Skip to content
This repository has been archived by the owner on Sep 25, 2023. It is now read-only.

Add/fix installation sections for SDR example notebooks #476

Merged
merged 3 commits into from
Apr 20, 2022
Merged

Add/fix installation sections for SDR example notebooks #476

merged 3 commits into from
Apr 20, 2022

Conversation

charlesbluca
Copy link
Member

  • Adjusts the installation section for the RTL-SDR example notebook to properly install all of the NeMo ASR toolkit dependencies as well as SoapySDR with RTL-SDR support
  • Installs pyaudio + SoapySDR with LimeSDR support for the general SDR example notebook
  • Adds a disclaimer to both notebooks that they will not work without an SDR device connected

Closes #469
Closes #470

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions github-actions bot added the Python label Apr 6, 2022
awthomp
awthomp approved these changes Apr 6, 2022
View reviewed changes
Copy link
Member

@awthomp awthomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. These are excellent improvements.

@awthomp awthomp added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Apr 20, 2022
@awthomp
Copy link
Member

awthomp commented Apr 20, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 50b92be into rapidsai:branch-22.06 Apr 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@awthomp awthomp awthomp approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python
Projects
None yet
Milestone
No milestone
2 participants
@charlesbluca @awthomp