Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use grid_stride_range in kernel loops #1178

Merged
merged 10 commits into from
Jun 27, 2023

Conversation

harrism
Copy link
Member

@harrism harrism commented Jun 6, 2023

Closes #650

Description

Adds a dependency on Ranger and uses ranger::grid_stride_loop with a range-based for loop in outer loops in every raw kernel in cuSpatial. In the few cases where we had raw kernels without grid-stride loops, this adds one. Also adds guidance to the C++ developer guide.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added cmake Related to CMake code or build configuration libcuspatial Relates to the cuSpatial C++ library labels Jun 6, 2023
@harrism harrism added bug Something isn't working tech debt Related to improving software quality 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Jun 6, 2023
@harrism harrism changed the title Use grid_stride_range loops universally Use grid_stride_range in kernel loops Jun 6, 2023
@harrism harrism self-assigned this Jun 6, 2023
@harrism harrism marked this pull request as ready for review June 6, 2023 08:12
@harrism harrism requested review from a team as code owners June 6, 2023 08:12
Copy link
Contributor

@isVoid isVoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vyasr
Copy link
Contributor

vyasr commented Jun 9, 2023

Do we want to move ranger into the rapidsai org or somewhere else shared before we introduce a dependency on it here?

@harrism
Copy link
Member Author

harrism commented Jun 12, 2023

Do we want to move ranger into the rapidsai org or somewhere else shared before we introduce a dependency on it here?

I am not opposed to that. That would make it easier for e.g. cuDF to adopt it.

@harrism
Copy link
Member Author

harrism commented Jun 21, 2023

Decision is to merge this as-is for now. We can look at re-homing ranger if and when it is determined to be needed.

@harrism
Copy link
Member Author

harrism commented Jun 21, 2023

/merge

@rapids-bot rapids-bot bot merged commit 7cb3000 into rapidsai:branch-23.08 Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working cmake Related to CMake code or build configuration libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change tech debt Related to improving software quality
Projects
Status: Review
Development

Successfully merging this pull request may close these issues.

[BUG] Should use grid-stride loop for several refactored APIs
4 participants