Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use rapids-cmake to supply Google Benchmark library. #1224

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Use rapids-cmake to supply Google Benchmark library. #1224

merged 1 commit into from
Jul 20, 2023

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Jul 20, 2023

Description

This PR updates cuspatial to use rapids-cmake to supply its Google Benchmark (gbench, also called benchmark) dependency.

Currently I am unable to build cuspatial in a rapids-compose environment with cudf because cuspatial and cudf expect different versions of benchmark (rapids-cmake and cudf use 1.8.0, while cuspatial is pinned at 1.5.3).

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice requested a review from a team as a code owner July 20, 2023 00:56
@bdice bdice requested a review from thomcom July 20, 2023 00:56
@github-actions github-actions bot added cmake Related to CMake code or build configuration libcuspatial Relates to the cuSpatial C++ library labels Jul 20, 2023
@bdice bdice self-assigned this Jul 20, 2023
@bdice bdice added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 20, 2023
@bdice
Copy link
Contributor Author

bdice commented Jul 20, 2023

/merge

@rapids-bot rapids-bot bot merged commit 7f3231c into rapidsai:branch-23.08 Jul 20, 2023
43 checks passed
@bdice bdice mentioned this pull request Jul 20, 2023
Merged
3 tasks
rapids-bot bot pushed a commit that referenced this pull request Jul 21, 2023
@bdice
Use Google Benchmark from rapids-cmake in cuproj. (#1225)
7cacad2 
Follow-up to #1224 for cuproj.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Robert Maynard (https://github.com/robertmaynard)

URL: #1225
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertmaynard robertmaynard robertmaynard approved these changes

@harrism harrism harrism approved these changes

@thomcom thomcom Awaiting requested review from thomcom thomcom is a code owner automatically assigned from rapidsai/cuspatial-cmake-codeowners

Assignees

@bdice bdice

Labels
cmake Related to CMake code or build configuration improvement Improvement / enhancement to an existing function libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change
Projects
cuSpatial
Status: Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bdice @robertmaynard @harrism