Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip CMake 3.30.0 #1401

Merged
merged 2 commits into from
Jul 9, 2024
Merged

skip CMake 3.30.0 #1401

merged 2 commits into from
Jul 9, 2024

Conversation

jameslamb
Copy link
Member

Description

Contributes to rapidsai/build-planning#80

Adds constraints to avoid pulling in CMake 3.30.0, for the reasons described in that issue.

@jameslamb jameslamb added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Jul 5, 2024
@github-actions github-actions bot added conda Related to conda and conda configuration Python Related to Python code labels Jul 5, 2024
@jameslamb
Copy link
Member Author

Tests here are failing with errors that look like they're probably related to cudf, not this change.

FAILED tests/test_geodataframe.py::test_interleaved_lines - TypeError: object of type 'bool' has no len()
FAILED tests/test_geodataframe.py::test_interleaved_polygons - TypeError: object of type 'bool' has no len()
FAILED tests/test_geodataframe.py::test_to_geopandas_with_geopandas_dataset - TypeError: object of type 'bool' has no len()
FAILED tests/test_geodataframe.py::test_to_shapely_random - TypeError: object of type 'bool' has no len()
FAILED tests/test_geodataframe.py::test_pre_slice[pre_slice0] - TypeError: object of type 'bool' has no len()
FAILED tests/test_geodataframe.py::test_pre_slice[pre_slice1] - TypeError: object of type 'bool' has no len()
FAILED tests/test_geodataframe.py::test_pre_slice[pre_slice2] - TypeError: object of type 'bool' has no len()
FAILED tests/test_geodataframe.py::test_pre_slice[pre_slice3] - TypeError: object of type 'bool' has no len()
FAILED tests/test_geodataframe.py::test_pre_slice[pre_slice4] - TypeError: object of type 'bool' has no len()
...
...
/opt/conda/envs/test/lib/python3.9/site-packages/cudf/core/series.py:629: TypeError

(build link)

@jameslamb jameslamb marked this pull request as ready for review July 5, 2024 22:09
@jameslamb jameslamb requested a review from a team as a code owner July 5, 2024 22:09
@jameslamb
Copy link
Member Author

The tests failures here look identical to the ones observed over in #1402.

See #1402 (comment), which says they're probably related to #1400 .

@bdice
Copy link
Contributor

bdice commented Jul 9, 2024

/merge

@rapids-bot rapids-bot bot merged commit 400cbe3 into rapidsai:branch-24.08 Jul 9, 2024
70 checks passed
@jameslamb jameslamb deleted the cmake-pin branch July 9, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conda Related to conda and conda configuration improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Related to Python code
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

3 participants