Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tool.scikit-build.cmake.version, set scikit-build-core minimum-version #1430

Merged
merged 6 commits into from
Aug 12, 2024

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Aug 7, 2024

Contributes to rapidsai/build-planning#58.

scikit-build-core==0.10.0 was released today (https://github.com/scikit-build/scikit-build-core/releases/tag/v0.10.0), and wheel-building configurations across RAPIDS are incompatible with it.

This proposes upgrading to that version and fixing configuration here in a way that:

  • is compatible with that new scikit-build-core version
  • takes advantage of the forward-compatibility mechanism (minimum-version) that scikit-build-core provides, to reduce the risk of needing to do this again in the future

@jameslamb jameslamb added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 7, 2024
@github-actions github-actions bot added conda Related to conda and conda configuration Python Related to Python code labels Aug 7, 2024
@jameslamb jameslamb changed the base branch from branch-24.08 to branch-24.10 August 7, 2024 14:15
@jameslamb
Copy link
Member Author

CI is in a bad state here, I don't think it's a result of this PR's changes.

We'll need to merge rapidsai/devcontainers#377 to fix the devcontainers builds. And then these others to fix other parts of CI:

I'll check back on this after merging those, before putting this up for review.

@jameslamb
Copy link
Member Author

Reported the test failures in #1433.

The changes in this PR are ready for review.

@jameslamb jameslamb changed the title WIP: Use tool.scikit-build.cmake.version, set scikit-build-core minimum-version Use tool.scikit-build.cmake.version, set scikit-build-core minimum-version Aug 7, 2024
@jameslamb jameslamb marked this pull request as ready for review August 7, 2024 16:58
@jameslamb jameslamb requested a review from a team as a code owner August 7, 2024 16:58
@jameslamb jameslamb requested a review from AyodeAwe August 7, 2024 16:58
@jakirkham
Copy link
Member

Restarting failed CI jobs now that devcontainers have been updated

@jakirkham
Copy link
Member

/merge

@jameslamb
Copy link
Member Author

This will be blocked until #1434 is complete

@vyasr
Copy link
Contributor

vyasr commented Aug 12, 2024

Restarted again now that #1434 is merged.

@rapids-bot rapids-bot bot merged commit 93a1653 into rapidsai:branch-24.10 Aug 12, 2024
69 checks passed
@jameslamb jameslamb deleted the scikit-build-core-version branch August 12, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conda Related to conda and conda configuration improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Related to Python code
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

4 participants