xfail Python tests dependent on invalid Polygons #1467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Python
vyasr
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Approving to unblock the 24.10 release. It would be good to get confirmation from a cuspatial developer more familiar with these tests to determine if these tests are important and indicative of some real issue that we need to address, but I don't think it's worth having cuspatial hold up the release so if needed we can release a hotfix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Appears the
gsfixture in theconftest.pycontains invalid polygon (the holes are beyond shell), and geos 3.13 now does not consider the same invalid polygon equivalent libgeos/geos#1177.The
gsfixture and thepolysfixture (which is hard-coded) need to both be updated, but I wasn't able to get a quick-working fix (I'm not familiar with this area). This PR just xfails the effected tests.Checklist