Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and test with CUDA 12.5.1 #219

Merged
merged 4 commits into from
Jul 16, 2024

Conversation

KyleFromNVIDIA
Copy link
Contributor

@KyleFromNVIDIA KyleFromNVIDIA commented Jul 11, 2024

This PR updates the latest CUDA build/test version 12.2.2 to 12.5.1.

Contributes to rapidsai/build-planning#73

@KyleFromNVIDIA KyleFromNVIDIA added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Jul 11, 2024
@KyleFromNVIDIA KyleFromNVIDIA marked this pull request as ready for review July 16, 2024 13:28
@KyleFromNVIDIA KyleFromNVIDIA requested review from a team as code owners July 16, 2024 13:28
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small change, looks like the conda env file mentioned here needs to be updated:

mamba env create --name cuvs -f conda/environments/all_cuda-120_arch-x86_64.yaml

And I think we'll want to update these cuda-version references in docs as well:

mamba install -c rapidsai -c conda-forge -c nvidia libcuvs cuda-version=12.0

mamba install -c rapidsai -c conda-forge -c nvidia libcuvs cuda-version=12.0

mamba install -c rapidsai -c conda-forge -c nvidia cuvs cuda-version=12.0

context: rapidsai/cudf#16259 (comment)

Marking this "approve" so you don't have to wait for another review from me.

@KyleFromNVIDIA KyleFromNVIDIA requested a review from a team as a code owner July 16, 2024 17:14
@KyleFromNVIDIA
Copy link
Contributor Author

I've updated https://github.com/rapidsai/rapids-reviser/pull/42 to also update .rst files.

Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thank you.

@jakirkham
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 27f816c into rapidsai:branch-24.08 Jul 16, 2024
54 checks passed
rapids-bot bot pushed a commit that referenced this pull request Jul 17, 2024
Follow up to PR: #219
Partially addresses issue: rapidsai/build-planning#73

Renames the `.devcontainer`s for CUDA 12.5

cc @KyleFromNVIDIA @jameslamb @trxcllnt (for awareness)

Authors:
  - https://github.com/jakirkham

Approvers:
  - Paul Taylor (https://github.com/trxcllnt)
  - James Lamb (https://github.com/jameslamb)

URL: #224
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
Development

Successfully merging this pull request may close these issues.

4 participants