Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use runtime check of cudart version for eig #2430

Open
wants to merge 5 commits into
base: branch-24.10
Choose a base branch
from
Open

Use runtime check of cudart version for eig #2430

wants to merge 5 commits into from

Conversation

lowener
Copy link
Contributor

@lowener lowener commented Sep 11, 2024

No description provided.

@lowener lowener added bug Something isn't working 3 - Ready for Review non-breaking Non-breaking change labels Sep 11, 2024
@lowener lowener requested a review from a team as a code owner September 11, 2024 12:25
@github-actions github-actions bot added the cpp label Sep 11, 2024
bdice
bdice approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right to me. @lowener Were you able to verify that this fixes the problem?

@lowener
Copy link
Contributor Author

lowener commented Sep 16, 2024

@bdice Yes, by using the CI image and the build artifact from this PR I found that the test is now passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

@bdice bdice bdice approved these changes

Assignees
No one assigned
Labels
5 - Ready to Merge bug Something isn't working cpp non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lowener @cjnolet @bdice