[Feat] add repeat, sparsity, eval_n_elements APIs to bitset
#2439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rhdong
commented
Sep 18, 2024
rhdong
commented
- This PR is a part of the feature that applies the prefilter brute-force in Cagra.
rhdong
added
enhancement
lowener
requested changes
Sep 19, 2024
| auto nnz_view = raft::make_device_scalar_view<index_t>(nnz.data()); | ||
| auto size_view = raft::make_host_scalar_view<index_t>(&size_h); | ||
|
|
||
| raft::popc(res, vector_view, size_view, nnz_view); |
There was a problem hiding this comment.
The count() method can also be implemented in bitset_view, it will be useful for users.
There was a problem hiding this comment.
I am also noticing that if the number of bits is not a multiple of the bitset element size the result might be wrong.
There was a problem hiding this comment.
I am also noticing that if the number of bits is not a multiple of the bitset element size the result might be wrong.
Should not, because the size is the actual number of bits. Maybe I miss something?
| @@ -145,6 +194,37 @@ class BitsetTest : public testing::TestWithParam<test_spec_bitset> { | |||
| resource::sync_stream(res, stream); | |||
| ASSERT_TRUE(hostVecMatch(bitset_ref, bitset_result, raft::Compare<bitset_t>())); | |||
|
|
|||
| // test sparsity, repeat and eval_n_elements | |||
| if constexpr (std::is_same_v<bitset_t, uint32_t> || std::is_same_v<bitset_t, uint64_t>) { | |||
There was a problem hiding this comment.
Why restrict the test to those data types?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.