Skip to content

Commit

Permalink
address review
Browse files Browse the repository at this point in the history
  • Loading branch information
Matt711 committed Sep 25, 2024
1 parent bfe271c commit efe3a48
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 18 deletions.
5 changes: 0 additions & 5 deletions python/rmm/rmm/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,7 @@
def __getattr__(name):
if name == "_lib":
import importlib
import warnings

warnings.warn(
"The `rmm._lib` module is deprecated in will be removed in a future release. Use `rmm.pylibrmm` instead.",
FutureWarning,
)
module = importlib.import_module("rmm.pylibrmm")
return module
else:
Expand Down
7 changes: 0 additions & 7 deletions python/rmm/rmm/_lib/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,4 @@
# See the License for the specific language governing permissions and
# limitations under the License.

import warnings

warnings.warn(
"The `rmm._lib` module is deprecated in will be removed in a future release. Use `rmm.pylibrmm` instead.",
FutureWarning,
)

from rmm.pylibrmm import *
6 changes: 0 additions & 6 deletions python/rmm/rmm/tests/test_rmm.py
Original file line number Diff line number Diff line change
Expand Up @@ -1076,9 +1076,3 @@ def test_available_device_memory():
assert initial_memory[1] == final_memory[1]
assert initial_memory[0] > 0
assert final_memory[0] > 0


# TODO: Remove test when rmm._lib is removed in 24.12
def test_deprecate_rmm_lib():
with pytest.warns(FutureWarning):
rmm._lib.device_buffer.DeviceBuffer(size=100)

0 comments on commit efe3a48

Please sign in to comment.