Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to using rapids-cmake for gbench. #1139

Merged
merged 1 commit into from
Oct 26, 2022
Merged

Switch to using rapids-cmake for gbench. #1139

merged 1 commit into from
Oct 26, 2022

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Oct 25, 2022

Description

Switch to using a centralized rapids-cmake function for getting Google benchmark

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added 3 - Ready for review Ready for review by team CMake non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Oct 25, 2022
@vyasr vyasr requested a review from a team as a code owner October 25, 2022 20:58
@vyasr vyasr self-assigned this Oct 25, 2022
@bdice
Copy link
Contributor

bdice commented Oct 26, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 4de6eec into rapidsai:branch-22.12 Oct 26, 2022
@vyasr vyasr deleted the feature/rapids_cpm_gbench branch October 26, 2022 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertmaynard robertmaynard robertmaynard approved these changes

@bdice bdice bdice approved these changes

Assignees

@vyasr vyasr

Labels
3 - Ready for review Ready for review by team CMake improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vyasr @bdice @robertmaynard