Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RMM PyTorch allocator #1168

Merged
merged 18 commits into from
Jan 5, 2023
Merged

Commits on Nov 29, 2022

  1. Add RMM PyTorch allocator

    shwina committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    f1e9413 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    53a18ab View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    aab7e07 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2022

  1. Add tests

    shwina committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    63f2692 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3fcd2ec View commit details
    Browse the repository at this point in the history
  3. Styles

    shwina committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    6404dac View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2022

  1. Configuration menu
    Copy the full SHA
    73e0846 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dc16ef4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9c27e85 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    39251db View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2022

  1. More doc

    shwina committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    6713361 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2022

  1. Configuration menu
    Copy the full SHA
    a53ce95 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2022

  1. Ensure UpstreamResourceAdaptor is not cleared by the Python GC (rap…

    …idsai#1170)
    
    Closes rapidsai#1169.
    
    Essentially, we are running into the situation described in https://cython.readthedocs.io/en/latest/src/userguide/extension_types.html#disabling-cycle-breaking-tp-clear with `UpstreamResourceAdaptor`.
    
    The solution is to prevent clearing of `UpstreamResourceAdaptor` objects by decorating them with `no_gc_clear`.
    
    Cython calls out the following:
    
    > If you use no_gc_clear, it is important that any given reference cycle contains at least one object without no_gc_clear. Otherwise, the cycle cannot be broken, which is a memory leak.
    
    The other object in RMM that we mark `@no_gc_clear` is `DeviceBuffer`, and a `DeviceBuffer` can keep a reference to an `UpstreamResourceAdaptor`. But, an `UpstreamResourceAdaptor` cannot keep a reference to a `DeviceBuffer`, so instances of the two cannot form a reference cycle AFAICT.
    
    Authors:
      - Ashwin Srinath (https://github.com/shwina)
    
    Approvers:
      - Vyas Ramasubramani (https://github.com/vyasr)
      - Mark Harris (https://github.com/harrism)
    
    URL: rapidsai#1170
    shwina committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    741a1df View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2022

  1. Delete __init__.py in tests/

    shwina committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    4534bca View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dbf43b7 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2022

  1. styles

    shwina committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    db5fc52 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2023

  1. Configuration menu
    Copy the full SHA
    2b343c2 View commit details
    Browse the repository at this point in the history
  2. Address reviews

    shwina committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    232fbd0 View commit details
    Browse the repository at this point in the history