-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RMM PyTorch allocator #1168
Merged
Merged
Commits on Nov 29, 2022
-
Configuration menu - View commit details
-
Copy full SHA for f1e9413 - Browse repository at this point
Copy the full SHA f1e9413View commit details -
Configuration menu - View commit details
-
Copy full SHA for 53a18ab - Browse repository at this point
Copy the full SHA 53a18abView commit details -
Configuration menu - View commit details
-
Copy full SHA for aab7e07 - Browse repository at this point
Copy the full SHA aab7e07View commit details
Commits on Nov 30, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 63f2692 - Browse repository at this point
Copy the full SHA 63f2692View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3fcd2ec - Browse repository at this point
Copy the full SHA 3fcd2ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6404dac - Browse repository at this point
Copy the full SHA 6404dacView commit details
Commits on Dec 13, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 73e0846 - Browse repository at this point
Copy the full SHA 73e0846View commit details -
Configuration menu - View commit details
-
Copy full SHA for dc16ef4 - Browse repository at this point
Copy the full SHA dc16ef4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c27e85 - Browse repository at this point
Copy the full SHA 9c27e85View commit details -
Configuration menu - View commit details
-
Copy full SHA for 39251db - Browse repository at this point
Copy the full SHA 39251dbView commit details
Commits on Dec 14, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 6713361 - Browse repository at this point
Copy the full SHA 6713361View commit details
Commits on Dec 15, 2022
-
Configuration menu - View commit details
-
Copy full SHA for a53ce95 - Browse repository at this point
Copy the full SHA a53ce95View commit details
Commits on Dec 19, 2022
-
Ensure
UpstreamResourceAdaptor
is not cleared by the Python GC (rap……idsai#1170) Closes rapidsai#1169. Essentially, we are running into the situation described in https://cython.readthedocs.io/en/latest/src/userguide/extension_types.html#disabling-cycle-breaking-tp-clear with `UpstreamResourceAdaptor`. The solution is to prevent clearing of `UpstreamResourceAdaptor` objects by decorating them with `no_gc_clear`. Cython calls out the following: > If you use no_gc_clear, it is important that any given reference cycle contains at least one object without no_gc_clear. Otherwise, the cycle cannot be broken, which is a memory leak. The other object in RMM that we mark `@no_gc_clear` is `DeviceBuffer`, and a `DeviceBuffer` can keep a reference to an `UpstreamResourceAdaptor`. But, an `UpstreamResourceAdaptor` cannot keep a reference to a `DeviceBuffer`, so instances of the two cannot form a reference cycle AFAICT. Authors: - Ashwin Srinath (https://github.com/shwina) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) - Mark Harris (https://github.com/harrism) URL: rapidsai#1170
Configuration menu - View commit details
-
Copy full SHA for 741a1df - Browse repository at this point
Copy the full SHA 741a1dfView commit details
Commits on Dec 20, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 4534bca - Browse repository at this point
Copy the full SHA 4534bcaView commit details -
Configuration menu - View commit details
-
Copy full SHA for dbf43b7 - Browse repository at this point
Copy the full SHA dbf43b7View commit details
Commits on Dec 21, 2022
-
Configuration menu - View commit details
-
Copy full SHA for db5fc52 - Browse repository at this point
Copy the full SHA db5fc52View commit details
Commits on Jan 5, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 2b343c2 - Browse repository at this point
Copy the full SHA 2b343c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 232fbd0 - Browse repository at this point
Copy the full SHA 232fbd0View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.