Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use fetch_rapids.cmake. #1319

Merged
merged 2 commits into from
Aug 1, 2023
Merged

Use fetch_rapids.cmake. #1319

merged 2 commits into from
Aug 1, 2023

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Aug 1, 2023

Description

This PR migrates RMM to use fetch_rapids.cmake like most RAPIDS repos. This makes it easier to define a single source if the upstream branch of rapids-cmake needs to change for testing, like in #1247.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Aug 1, 2023
@bdice bdice requested a review from a team as a code owner August 1, 2023 16:27
@bdice bdice self-assigned this Aug 1, 2023
@github-actions github-actions bot added CMake Python Related to RMM Python API labels Aug 1, 2023
@bdice bdice mentioned this pull request Aug 1, 2023
Closed
robertmaynard
robertmaynard requested changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@robertmaynard robertmaynard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update update-version.sh as well

@bdice bdice requested a review from a team as a code owner August 1, 2023 17:29
@github-actions github-actions bot added the ci label Aug 1, 2023
@bdice
Copy link
Contributor Author

bdice commented Aug 1, 2023

/merge

@rapids-bot rapids-bot bot merged commit c4618eb into rapidsai:branch-23.10 Aug 1, 2023
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertmaynard robertmaynard robertmaynard approved these changes

@raydouglass raydouglass raydouglass approved these changes

Assignees

@bdice bdice

Labels
ci CMake improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Related to RMM Python API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bdice @robertmaynard @raydouglass