-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python bindings for limiting_resource_adaptor
#1327
Merged
rapids-bot
merged 5 commits into
rapidsai:branch-23.10
from
pentschev:python-limiting-resource
Aug 21, 2023
Merged
Add Python bindings for limiting_resource_adaptor
#1327
rapids-bot
merged 5 commits into
rapidsai:branch-23.10
from
pentschev:python-limiting-resource
Aug 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pentschev
force-pushed
the
python-limiting-resource
branch
from
August 21, 2023 13:50
0caac1d
to
2e32ca9
Compare
wence-
reviewed
Aug 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very minor quibbles, but overall looks great.
wence-
added
non-breaking
Non-breaking change
improvement
Improvement / enhancement to an existing function
labels
Aug 21, 2023
wence-
approved these changes
Aug 21, 2023
vyasr
approved these changes
Aug 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. One small suggestion, will apply then merge.
/merge |
Thanks @vyasr ! |
And thanks @wence- as well! 😄 |
rapids-bot bot
pushed a commit
to rapidsai/dask-cuda
that referenced
this pull request
Aug 22, 2023
In addition to the `release_threshold`, enable as well support for the `maximum_pool_size`. The difference between the two is that `release_threshold` will attempt to bring RMM's memory usage down to that value after the next stream synchronization, whereas `maximum_pool_size` is a hard limit enforced by RMM. Depends on rapidsai/rmm#1327. Authors: - Peter Andreas Entschev (https://github.com/pentschev) Approvers: - Benjamin Zaitlen (https://github.com/quasiben) URL: #1221
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
Python
Related to RMM Python API
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Python bindings for the
limiting_resource_adaptor
via a new Python memory resourceLimitingResourceAdaptor
.Checklist