Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cmake-format version for pre-commit and environments. #995

Merged
merged 2 commits into from
Apr 25, 2022
Merged

Update cmake-format version for pre-commit and environments. #995

merged 2 commits into from
Apr 25, 2022

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Mar 15, 2022

Update to cmake-format 0.6.13.

@vyasr vyasr added 3 - Ready for review Ready for review by team CMake non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Mar 15, 2022
@vyasr vyasr requested a review from a team as a code owner March 15, 2022 22:55
@vyasr vyasr self-assigned this Mar 15, 2022
@vyasr
Copy link
Contributor Author

vyasr commented Mar 15, 2022

CC @robertmaynard

@github-actions github-actions bot added conda and removed CMake labels Mar 15, 2022
@ajschmidt8
Copy link
Member

Just waiting on this PR before giving an ops-codeowner approval:

@vyasr vyasr added 5 - DO NOT MERGE Hold off on merging; see PR for details and removed 3 - Ready for review Ready for review by team labels Mar 16, 2022
@harrism
Copy link
Member

harrism commented Mar 23, 2022

Looks like this should move to 22.06 for code freeze.

@vyasr
Copy link
Contributor Author

vyasr commented Apr 19, 2022

This PR is currently blocked by rapidsai/integration#441.

@vyasr vyasr force-pushed the feature/update_cmake_format branch from ca0b6c4 to 3c96227 Compare April 21, 2022 21:19
@github-actions github-actions bot added CMake cpp Pertains to C++ code gpuCI Python Related to RMM Python API labels Apr 21, 2022
@vyasr vyasr changed the base branch from branch-22.04 to branch-22.06 April 21, 2022 21:19
@vyasr vyasr requested review from a team as code owners April 21, 2022 21:19
@vyasr vyasr requested a review from cwharris April 21, 2022 21:19
@vyasr vyasr requested review from codereport and removed request for a team, cwharris and codereport April 21, 2022 21:19
@vyasr vyasr removed Python Related to RMM Python API gpuCI cpp Pertains to C++ code labels Apr 21, 2022
@github-actions github-actions bot removed the CMake label Apr 21, 2022
@ajschmidt8
Copy link
Member

rerun tests

@vyasr vyasr added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 5 - DO NOT MERGE Hold off on merging; see PR for details labels Apr 25, 2022
@vyasr
Copy link
Contributor Author

vyasr commented Apr 25, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit ab4b81a into rapidsai:branch-22.06 Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertmaynard robertmaynard robertmaynard approved these changes

@harrism harrism harrism approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

Assignees

@vyasr vyasr

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge conda improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vyasr @ajschmidt8 @harrism @robertmaynard