Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CUDA version to 12.5.1 #229

Merged
merged 4 commits into from
Jul 19, 2024
Merged

Update CUDA version to 12.5.1 #229

merged 4 commits into from
Jul 19, 2024

Conversation

KyleFromNVIDIA
Copy link
Contributor

@KyleFromNVIDIA KyleFromNVIDIA requested a review from a team as a code owner July 11, 2024 16:53
@KyleFromNVIDIA KyleFromNVIDIA requested review from AyodeAwe and removed request for a team July 11, 2024 16:53
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're going to drop ALL coverage of CUDA 12.2 in across building and testing, then we should also be replacing the CUDA 12.2 end-user container images with CUDA 12.5 images: rapidsai/build-planning#73 (comment)

If we're going to keep publishing CUDA 12.2 container images for the 24.08 release, then I think we should preserve at least some coverage of 12.2.2 in nightly CI.

Have you already considered that? If not, then I think that's a conversation we need to have with all the build and ops folks.

I'll start a thread offline.

@jameslamb jameslamb self-requested a review July 19, 2024 14:29
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, and for keeping the matrices sorted 😁

@raydouglass raydouglass merged commit 8418b62 into branch-24.08 Jul 19, 2024
@raydouglass raydouglass deleted the cuda-12.5.1 branch July 19, 2024 14:43
@raydouglass raydouglass restored the cuda-12.5.1 branch July 19, 2024 14:43
@jakirkham
Copy link
Member

As we already switched all the projects back to branch-24.08, am going to delete cuda-12.5.1

If for some reason we missed something somewhere, now is the time to find out

Also if I goofed in some major way there is the restore button to bring it back

@jakirkham jakirkham deleted the cuda-12.5.1 branch July 25, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants