refactor dependency-file-generator handling of cupy, default to CUDA 12 in fallback dependency lists #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
commented
Jul 25, 2024
| - cupy>=12.0.0 | ||
| # NOTE: This is intentionally not broken into groups by a 'cuda_suffixed' selector like | ||
| # other packages with -cu{nn}x suffixes in this file. | ||
| # All RAPIDS wheel builds (including in devcontainers) expect cupy to be suffixed. |
There was a problem hiding this comment.
this is exactly the language I'm proposing over in rapidsai/cugraph#4552 (comment) as well
jameslamb
changed the title
bdice
approved these changes
Jul 25, 2024
jameslamb
changed the title
|
/merge |
jakirkham
reviewed
Jul 25, 2024
| - | | ||
| pip install \ | ||
| -C rapidsai.matrix-entry="cuda=12.2;cuda_suffixed=true" \ | ||
| -C rapidsai.matrix-entry="cuda=12.x;cuda_suffixed=true" \ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #1057.
Implements the following suggestions based on review comments from @jakirkham and @bdice there:
cupyout into its own list independencies.yaml, to allow removing somecuda_suffixed: "false"blocks that were otherwise redundant--matrix-entry 'cuda=12.x'in docs builds, to make it clearer that those builds are just trying to matchcuda: "12.*"and are not at all dependent on any particular minor version of CUDAAlso proposes defaulting to
cupy-cuda12xinpyproject.toml, as part of rapidsai/build-planning#68.