Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable UCP_FEATURE_WAKEUP in non-blocking mode #565

Open
wants to merge 2 commits into
base: branch-0.15
Choose a base branch
from

Conversation

pentschev
Copy link
Member

@pentschev pentschev commented Jul 24, 2020

This is currently the only way to enable shared memory support.

See openucx/ucx#5322 for the discussion about it.

This is currently the only way to enable shared memory support.
@quasiben
Copy link
Member

Looks good. Currently failing on flake8:

./ucp/core.py:240:89: E501 line too long (106 > 88 characters)

Do you think it's worth exposing ucp_params to the Python layer. Not to set but only for getting. This would allow us to test and others to confirm UCP configurations.

@pentschev
Copy link
Member Author

Thanks for pinging @quasiben , I hadn't seen the error before, should be fixed now.

Do you think it's worth exposing ucp_params to the Python layer. Not to set but only for getting. This would allow us to test and others to confirm UCP configurations.

I don't know, maybe? TBH, I'm ignorant of that, is that information useful at runtime somehow? Also note that UCXWorker too has a similar worker_params that aren't exposed. Maybe it would make more sense to open an issue to discuss if it's useful/worth to expose those?

@pentschev
Copy link
Member Author

Failures are legit, I'm trying to find out whether disabling UCP_FEATURE_WAKEUP is indeed supposed to work in all cases or if there are any limitations, which seems to be the case.

@pentschev
Copy link
Member Author

Ok, this is an issue in UCX 1.8.x but as per my local tests it works in 1.9.x, so we'll need to wait for that to merge this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants