Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyproject.toml file. #894

Merged
merged 3 commits into from
Nov 4, 2022

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Nov 2, 2022

This file is required for using newer PEP517-compliant projects.

Copy link
Member

@madsbk madsbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @vyasr

pyproject.toml Outdated Show resolved Hide resolved
Co-authored-by: jakirkham <jakirkham@gmail.com>
@pentschev
Copy link
Member

rerun tests

pyproject.toml Outdated Show resolved Hide resolved
@vyasr
Copy link
Contributor Author

vyasr commented Nov 4, 2022

Thanks John, I wasn't quite sure what the new build_meta behavior would imply so I figured I'd try it out.

@jakirkham
Copy link
Member

Yeah of course. Thanks for giving it a try Vyas 🙂

Think we just haven't moved enough over to pyproject.toml yet. My guess is once most things are moved over it should work. Going to give this a try after merging

@jakirkham jakirkham merged commit e6dae58 into rapidsai:branch-0.29 Nov 4, 2022
@vyasr vyasr deleted the feature/pyproject_toml branch November 4, 2022 00:41
@vyasr
Copy link
Contributor Author

vyasr commented Nov 4, 2022

Improving the non-conda (and conda too of course, but that part is in a better place) packaging of RAPIDS packages is going to be something I invest a decent bit of time into in the near future as we roll out wheels (No pun intended 😄).

@jakirkham
Copy link
Member

jakirkham commented Nov 4, 2022

Yeah Python has been moving more steadily towards declarative metadata for packaging, which is a good thing all around.

To get a sense of what I mean by move more things over to pyproject.toml, PR ( #895 ) is what I'm thinking. Proposed similar changes to RMM ( rapidsai/rmm#1151 ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants