Build and test with CUDA 12.5.1 #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KyleFromNVIDIA
added
non-breaking
|
After offline discussion with @robertmaynard, we've come to the conclusion that nvml should be dynamically linked after all. I've updated this PR to do so. |
jameslamb
approved these changes
Jul 16, 2024
|
/merge |
bdice
reviewed
Jul 23, 2024
| @@ -55,6 +55,7 @@ requirements: | |||
| - cudatoolkit | |||
| {% else %} | |||
| - cuda-cudart-dev | |||
| - cuda-nvml-dev | |||
There was a problem hiding this comment.
This change needed an entry in dependencies.yaml as well. See rapidsai/devcontainers#366 (comment). In devcontainers, we see:
2024-07-22T21:24:02.4790079Z CMake Error at CMakeLists.txt:204 (target_link_libraries):
2024-07-22T21:24:02.4793870Z Target "wholegraph" links to:
2024-07-22T21:24:02.4798184Z
2024-07-22T21:24:02.4802582Z CUDA::nvml
2024-07-22T21:24:02.4804498Z
2024-07-22T21:24:02.4804898Z but the target was not found. Possible reasons include:
2024-07-22T21:24:02.4805252Z
2024-07-22T21:24:02.4805598Z * There is a typo in the target name.
2024-07-22T21:24:02.4810296Z * A find_package call is missing for an IMPORTED target.
2024-07-22T21:24:02.4811022Z * An ALIAS target is missing.
There was a problem hiding this comment.
Good catch. Thanks Bradley! 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the latest CUDA build/test version 12.2.2 to 12.5.1.
Contributes to rapidsai/build-planning#73