Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AuthServiceProvider #1227

Merged
merged 5 commits into from
Aug 21, 2019
Merged

Update AuthServiceProvider #1227

merged 5 commits into from
Aug 21, 2019

Conversation

bryanrscott
Copy link
Contributor

@bryanrscott bryanrscott commented Apr 2, 2019

Is this an enhancement

Assign all permissions to the Admin role without the need to explicitly assign the roles/permissions to the user.

As per spatie recommendation here : https://github.com/spatie/laravel-permission/wiki/Global-%22Admin%22-role

@lukecurtis93
Copy link

isn't the role called administrator on this boilerplate?

Use config setting for admin role name
@bryanrscott
Copy link
Contributor Author

Updated to use config setting for admin role name

@poseso
Copy link
Contributor

poseso commented Apr 21, 2019

you should use Gate; instead of Illuminate\Support\Facades\Gate; else all tests will fail

@bryanrscott
Copy link
Contributor Author

Updated import as suggested

rappasoft added a commit that referenced this pull request Aug 21, 2019
- Added Azerbaijan language (#1254)
- Added NIST Password Rules (#1258)

- Assign all permissions to the Admin role without the need to explicitly assign the roles/permissions to the user. (#1227)

- Removed default Google scopes (https://github.com/rappasoft/laravel-boilerplate/pull/1253/files)
- Removed ChangePassword rule as the new NIST rules cover it
@rappasoft rappasoft merged commit 0318e4c into rappasoft:master Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants