Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add-501-error-code-[NOT_IMPLEMENTED]-main #4

Conversation

ravindrapalaskar17
Copy link
Owner

@ravindrapalaskar17 ravindrapalaskar17 commented Jan 17, 2023

Refer to the issue (“Will fix camaraproject#81”).

At present we are throwing  404 BAD REQUEST code when user is sending valid input but NEF /CRISP are not process the same For E.g. (External ID , MSISDN , IPV4 and IPV6) are valid UE inputs for Qod-API, but NEF can process only (MSISDN and IPV6 ). 
in such case we should throw 501 code (NOT IMPLEMENTED)
So we are proposing 501 error code with this changes/commmit
@ravindrapalaskar17 ravindrapalaskar17 self-assigned this Jan 17, 2023
Copy link

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ravindrapalaskar17 ravindrapalaskar17 merged commit 2453d45 into Implement-error-code-501-main Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants