fix: use react-native convention for version overrides, allows AndroidX to work #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pronav if you can look at this and merge it, it'll help users - there are compile fails happening now related to it unfortunately |
mikehardy
added a commit
to mikehardy/rn-androidx-demo
that referenced
this pull request
Jun 19, 2019
this uncovers some latent resource errors (react-native-razorpay has one: razorpay/react-native-razorpay#201)
|
@mikehardy working fine now |
sumedht
approved these changes
Jun 19, 2019
|
Thanks @mikehardy for the neat fix! |
|
Happy to help - this actually helped me strengthen my tests for jetifier, and now that it's resolved everyone benefits on both sides. Cheers |
|
@pronav @sumedht React-Native 0.60 is in RC3 now, and will be released in the next couple days, if you don’t release this change, use of your library will result in broken builds for those using jetifier, the recommended way for developers to migrate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the standard way that react-native modules allow for overrides, and moves the default to 28 so AndroidX will work, otherwise users can't jetify your library and use AndroidX dependencies.
Mentioned here: react-native-netinfo/react-native-netinfo#107 (comment)