Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn if WORKDIR is not an absolute path #47

Closed
rcjsuen opened this issue Jun 2, 2018 · 0 comments
Closed

Warn if WORKDIR is not an absolute path #47

rcjsuen opened this issue Jun 2, 2018 · 0 comments
Assignees
@rcjsuen
Labels
enhancement

Comments

@rcjsuen
Copy link
Owner

rcjsuen commented Jun 2, 2018

According to the Dockerfile recommendations document, WORKDIR instructions should be an absolute path.

For clarity and reliability, you should always use absolute paths for your WORKDIR.

We should add a (configurable) diagnostic to flag this as an error or a warning (or completely ignored).
@rcjsuen rcjsuen self-assigned this Aug 11, 2018
rcjsuen added a commit that referenced this issue Aug 11, 2018
@rcjsuen
Fix #47 Add support for variables in WORKDIR
e10197f 
Variables that are used in a WORKDIR should be considered when
determining whether the instruction refers to an absolute path or not.

Signed-off-by: Remy Suen <remy.suen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rcjsuen rcjsuen

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rcjsuen